Hides worn PDAs

[Jacquerel]

About The Pull Request

PDAs no longer have a visible appearance on your character when equipped in the belt or ID slot.

Pictured:

Me uh... not visibly wearing a PDA?

Why It's Good For The Game

There's virtually no game advantage gained by knowing whether someone is or is not wearing a PDA, and even if there were they could just as easily have it in a pocket or other storage slot.
They create visual noise on your sprite and are an accessory that virtually everyone always has, making the game look worse.
When ID card sprites were restored as part of a bug fix when introducing missing worn icon unit testing, they were intentionally hidden again for similar reasons.

Changelog

🆑
imagedel: you can no longer tell if someone is wearing a PDA by looking at them
/:cl:

[san7890]

i kinda liked them but it's okay if the people actually dedicated to making uniforms desire it

[github-actions]

Screenshot tests failed!

Download zip file of new screenshots.

Diffs

See snapshot diffs

Name	Expected image	Produced image	Diff
screenshot_antag_icons_blobinfection
screenshot_antag_icons_bloodbrother
screenshot_antag_icons_headrevolutionary
screenshot_antag_icons_provocateur
screenshot_humanoids__datum_species_abductor
screenshot_humanoids__datum_species_android
screenshot_humanoids__datum_species_dullahan
screenshot_humanoids__datum_species_ethereal
screenshot_humanoids__datum_species_fly
screenshot_humanoids__datum_species_golem
screenshot_humanoids__datum_species_golem_adamantine
screenshot_humanoids__datum_species_golem_alloy
screenshot_humanoids__datum_species_golem_bananium
screenshot_humanoids__datum_species_golem_bluespace
screenshot_humanoids__datum_species_golem_bone
screenshot_humanoids__datum_species_golem_bronze
screenshot_humanoids__datum_species_golem_cardboard
screenshot_humanoids__datum_species_golem_cloth
screenshot_humanoids__datum_species_golem_diamond
screenshot_humanoids__datum_species_golem_durathread
screenshot_humanoids__datum_species_golem_glass
screenshot_humanoids__datum_species_golem_gold
screenshot_humanoids__datum_species_golem_leather
screenshot_humanoids__datum_species_golem_mhydrogen
screenshot_humanoids__datum_species_golem_plasma
screenshot_humanoids__datum_species_golem_plasteel
screenshot_humanoids__datum_species_golem_plastic
screenshot_humanoids__datum_species_golem_plastitanium
screenshot_humanoids__datum_species_golem_runic
screenshot_humanoids__datum_species_golem_sand
screenshot_humanoids__datum_species_golem_silver
screenshot_humanoids__datum_species_golem_snow
screenshot_humanoids__datum_species_golem_titanium
screenshot_humanoids__datum_species_golem_uranium
screenshot_humanoids__datum_species_golem_wood
screenshot_humanoids__datum_species_human
screenshot_humanoids__datum_species_human_felinid
screenshot_humanoids__datum_species_human_krokodil_addict
screenshot_humanoids__datum_species_jelly
screenshot_humanoids__datum_species_jelly_luminescent
screenshot_humanoids__datum_species_jelly_slime
screenshot_humanoids__datum_species_jelly_stargazer
screenshot_humanoids__datum_species_lizard_ashwalker
screenshot_humanoids__datum_species_lizard_silverscale
screenshot_humanoids__datum_species_monkey_monkey_freak
screenshot_humanoids__datum_species_moth
screenshot_humanoids__datum_species_mush
screenshot_humanoids__datum_species_plasmaman
screenshot_humanoids__datum_species_pod
screenshot_humanoids__datum_species_shadow
screenshot_humanoids__datum_species_skeleton
screenshot_humanoids__datum_species_snail
screenshot_humanoids__datum_species_vampire
screenshot_humanoids__datum_species_zombie
screenshot_humanoids__datum_species_zombie_infectious
screenshot_saturnx_invisibility

Help

What is this?

Screenshot tests make sure that specific icons look the same as they did before.
This is important for elements that often mistakenly change, such as alien species.

If the produced image looks broken, then it is possible your code caused a bug.
Make sure to test in game to see if you can fix it.

I am changing sprites, it's supposed to look different.

If the newly produced sprites are correct, then the tests should be updated.

You can either:

1. Right-click the "produced image", and save it in code/modules/unit_tests/screenshots/NAME.png.
2. Download and extract this zip file in the root of your repository, and commit.

If you need help, you can ask maintainers either on Discord or on this pull request.

This is a false positive.

If you are sure your code did not cause this failure, especially if it's inconsistent,
then you may have found a false positive.

Ask maintainers to rerun the test.

If you need help, you can ask maintainers either on Discord or on this pull request.

[timothymtorres]

Just add a bitflag that lets certain uniforms hide PDAs. They have this for hats, just do the same thing.

[ArcaneMusic]

So, this bares mentioning: Even though the icon_state is missing (set to "nothing"), we're still sending assets every time we do so, despite it being an empty sprite. This is part of the reason why we went through Spritemageddon.

To my understanding, this is currently no way to avoid sending an asset if the icon_state doesn't match that of the icon file. I don't know if we can hit that here, but as a general practice this is something we'd like to avoid doing.

[Mothblocks]

i was going to be sad but i literally can't tell the difference in any of those screenshot test comparisons

[thgvr]

Thank god. I don't think anyone will miss this.

[honkpocket]

Thank god. I don't think anyone will miss this.

me :(

[Acer202]

This always made a little dot on an otherwise perfect outfit, and I'd try to hide it by wearing the ID in the pocket. It was worth it, for style. Good riddance!