Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE 10/22: Removal of title bar/icons #9

Closed
pguevara65 opened this issue Oct 9, 2019 · 11 comments
Closed

UPDATE 10/22: Removal of title bar/icons #9

pguevara65 opened this issue Oct 9, 2019 · 11 comments
Assignees
Labels
bug Something isn't working P1 Top Priority - Needs to be completed prior to launch

Comments

@pguevara65
Copy link

https://drive.google.com/file/d/13Cs84EAN0pCSsWlO973LNiwo48bxRhfH/view?usp=sharing

@NoelWormwood NoelWormwood added bug Something isn't working P1 Top Priority - Needs to be completed prior to launch labels Oct 9, 2019
@cmoosman1 cmoosman1 assigned pguevara65 and unassigned cmoosman1 Oct 10, 2019
@cmoosman1
Copy link

@pguevara65 - This is resolved in the current build

@NoelWormwood NoelWormwood assigned jthiel16 and unassigned pguevara65 Oct 10, 2019
@NoelWormwood
Copy link
Collaborator

@jthiel16 Please review

@jthiel16
Copy link

  1. Can we left-align these modules to the same spot as the text heading just beneath it, at all sizes
  2. Employment page is missing this element. Suggest using the same icon as About Us
  3. Masonry/Steel/Stone pages are using a white icon for the selected page (let's make that black)
  4. These icons on the Masonry/Steel/Stone pages were intended to be links to the other pages, but it's missing that functionality. Hover states are in page 1 of UI kit.

@NoelWormwood NoelWormwood assigned cmoosman1 and unassigned jthiel16 Oct 16, 2019
@NoelWormwood
Copy link
Collaborator

@jthiel16 This ticket is for the internal title icons. Can we add the size adjustment requests here instead of creating a new ticket based upon our convo this morning.

@jthiel16
Copy link

@NoelWormwood @cmoosman1 Yeah, one additional thing to add to this list:

  1. The "header-icons-wrapper" div is appearing a bit too large and prominent. Let's reduce the height of that element on all interior pages, so it's at most 60px high

@NoelWormwood
Copy link
Collaborator

@jthiel16 Please QA

@jthiel16
Copy link

@NoelWormwood @cmoosman1

  1. Can we left-align these modules to the same spot as the text heading just beneath it, at all sizes
  2. Employment page is missing this element. Suggest using the same icon as About Us
  3. Masonry/Steel/Stone pages are using a white icon for the selected page (let's make that black)
  4. These icons on the Masonry/Steel/Stone pages were intended to be links to the other pages, but it's missing that functionality. Hover states are in page 1 of UI kit.
  5. The "header-icons-wrapper" div is appearing a bit too large and prominent. Let's reduce the height of that element on all interior pages, so it's at most 60px high

@NoelWormwood
Copy link
Collaborator

@cmoosman1 The Sargon team has decided that they would like to remove all page title bar/icons across the site.

Services page (Steel, Masonry, Stone)
About Us
Contact Us

@NoelWormwood NoelWormwood assigned cmoosman1 and unassigned jthiel16 Oct 22, 2019
@NoelWormwood NoelWormwood changed the title Internal pages are missing the page title bar/icons UPDATE 10/22: Removal of title bar/icons. Internal pages are missing the page title bar/icons Oct 22, 2019
@NoelWormwood NoelWormwood changed the title UPDATE 10/22: Removal of title bar/icons. Internal pages are missing the page title bar/icons UPDATE 10/22: Removal of title bar/icons Oct 22, 2019
@cmoosman1 cmoosman1 assigned NoelWormwood and unassigned cmoosman1 Oct 23, 2019
@cmoosman1
Copy link

@NoelWormwood - This is resolved in the current build

@pguevara65
Copy link
Author

@jthiel16 can you please review?

@cmoosman1 thanks!
cc: @NoelWormwood

@jthiel16
Copy link

Thanks Criss, closing the ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Top Priority - Needs to be completed prior to launch
Projects
None yet
Development

No branches or pull requests

4 participants