Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/angular query #6195

Merged
merged 45 commits into from
Dec 1, 2023
Merged

Feature/angular query #6195

merged 45 commits into from
Dec 1, 2023

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented Oct 19, 2023

Experimental Angular adapter

Uses signals, will support Angular 17+

The Svelte adapter served as a very good base, thanks! ❤️

Feedback is very welcome! Contact me on the Tanstack Discord in the angular-query channel or in this Github discussion.

To do

  • react to attribute changes of dev tools
  • find a solution for dev tools needing "skipLibCheck": true setting in app using them
  • reduce boilerplate for options signals
  • redo dependency injection and providers
    • improve query client mounting and unmounting
    • inject* functions such as injectQuery
  • injectInfiniteQuery
  • injectMutationState
  • docs
  • update unit tests to use the new function based API
  • more unit tests
  • more examples
  • integration test
image

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 0:42am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2af306d:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@arnoud-dv arnoud-dv force-pushed the feature/angular-query branch 4 times, most recently from f3a5445 to 204582a Compare November 1, 2023 20:26
docs/angular/devtools.md Outdated Show resolved Hide resolved
docs/angular/devtools.md Outdated Show resolved Hide resolved
docs/angular/devtools.md Outdated Show resolved Hide resolved
docs/angular/devtools.md Outdated Show resolved Hide resolved
@arnoud-dv arnoud-dv force-pushed the feature/angular-query branch 3 times, most recently from 49afbd1 to d75774b Compare November 14, 2023 18:25
Copy link

nx-cloud bot commented Nov 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2af306d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (af0ff9a) 0.00% compared to head (2af306d) 87.83%.

Files Patch % Lines
...ages/angular-query-experimental/src/query-proxy.ts 52.94% 8 Missing ⚠️
...s/angular-query-experimental/src/injectMutation.ts 94.11% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #6195       +/-   ##
=========================================
+ Coverage      0   87.83%   +87.83%     
=========================================
  Files         0       87       +87     
  Lines         0     2926     +2926     
  Branches      0      803      +803     
=========================================
+ Hits          0     2570     +2570     
- Misses        0      297      +297     
- Partials      0       59       +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TkDodo TkDodo merged commit 46034aa into TanStack:main Dec 1, 2023
10 checks passed
diegohaz pushed a commit to ariakit/ariakit that referenced this pull request Dec 2, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@tanstack/react-query](https://tanstack.com/query)
([source](https://togithub.com/TanStack/query)) | [`5.10.0` ->
`5.12.2`](https://renovatebot.com/diffs/npm/@tanstack%2freact-query/5.10.0/5.12.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@tanstack%2freact-query/5.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@tanstack%2freact-query/5.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@tanstack%2freact-query/5.10.0/5.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@tanstack%2freact-query/5.10.0/5.12.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>TanStack/query (@&#8203;tanstack/react-query)</summary>

###
[`v5.12.2`](https://togithub.com/TanStack/query/releases/tag/v5.12.2)

[Compare
Source](https://togithub.com/TanStack/query/compare/v5.12.1...v5.12.2)

Version 5.12.2 - 12/2/2023, 9:37 AM

##### Changes

##### Fix

- useQueries: add type tests for useQueries and fix a couple of type
bugs ([#&#8203;6471](https://togithub.com/TanStack/query/issues/6471))
([`b54936f`](https://togithub.com/TanStack/query/commit/b54936f1)) by
Charlotte Grace (Bone)

##### Docs

- angular-query: fix quickstart
([`23374bb`](https://togithub.com/TanStack/query/commit/23374bb4)) by
[@&#8203;eneajaho](https://togithub.com/eneajaho)
- angular-query: compatible with angular 17
([#&#8203;6469](https://togithub.com/TanStack/query/issues/6469))
([`ac046b1`](https://togithub.com/TanStack/query/commit/ac046b11)) by
Arnoud

##### Packages

-
[@&#8203;tanstack/react-query](https://togithub.com/tanstack/react-query)[@&#8203;5](https://togithub.com/5).12.2
-
[@&#8203;tanstack/vue-query](https://togithub.com/tanstack/vue-query)[@&#8203;5](https://togithub.com/5).12.2
-
[@&#8203;tanstack/react-query-devtools](https://togithub.com/tanstack/react-query-devtools)[@&#8203;5](https://togithub.com/5).12.2
-
[@&#8203;tanstack/react-query-persist-client](https://togithub.com/tanstack/react-query-persist-client)[@&#8203;5](https://togithub.com/5).12.2
-
[@&#8203;tanstack/react-query-next-experimental](https://togithub.com/tanstack/react-query-next-experimental)[@&#8203;5](https://togithub.com/5).12.2

###
[`v5.12.1`](https://togithub.com/TanStack/query/releases/tag/v5.12.1)

[Compare
Source](https://togithub.com/TanStack/query/compare/v5.12.0...v5.12.1)

Version 5.12.1 - 12/1/2023, 3:42 PM

##### Changes

##### Feat

- experimental angular query adapter
([TanStack/query#6195)
(TanStack/query@46034aa)
by Arnoud

##### Fix

- angular release process
([#&#8203;6468](https://togithub.com/TanStack/query/issues/6468))
([`4e8a6c5`](https://togithub.com/TanStack/query/commit/4e8a6c5a)) by
Dominik Dorfmeister

##### Chore

- Use prettier v4 alpha
([#&#8203;6466](https://togithub.com/TanStack/query/issues/6466))
([`3a60413`](https://togithub.com/TanStack/query/commit/3a60413d)) by
Lachlan Collins

##### Packages

-
[@&#8203;tanstack/eslint-plugin-query](https://togithub.com/tanstack/eslint-plugin-query)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-async-storage-persister](https://togithub.com/tanstack/query-async-storage-persister)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-broadcast-client-experimental](https://togithub.com/tanstack/query-broadcast-client-experimental)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-core](https://togithub.com/tanstack/query-core)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-devtools](https://togithub.com/tanstack/query-devtools)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-persist-client-core](https://togithub.com/tanstack/query-persist-client-core)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/query-sync-storage-persister](https://togithub.com/tanstack/query-sync-storage-persister)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/react-query](https://togithub.com/tanstack/react-query)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/react-query-devtools](https://togithub.com/tanstack/react-query-devtools)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/react-query-persist-client](https://togithub.com/tanstack/react-query-persist-client)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/react-query-next-experimental](https://togithub.com/tanstack/react-query-next-experimental)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/solid-query](https://togithub.com/tanstack/solid-query)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/solid-query-devtools](https://togithub.com/tanstack/solid-query-devtools)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/solid-query-persist-client](https://togithub.com/tanstack/solid-query-persist-client)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/svelte-query](https://togithub.com/tanstack/svelte-query)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/svelte-query-devtools](https://togithub.com/tanstack/svelte-query-devtools)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/svelte-query-persist-client](https://togithub.com/tanstack/svelte-query-persist-client)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/vue-query](https://togithub.com/tanstack/vue-query)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/vue-query-devtools](https://togithub.com/tanstack/vue-query-devtools)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/angular-query-devtools-experimental](https://togithub.com/tanstack/angular-query-devtools-experimental)[@&#8203;5](https://togithub.com/5).12.1
-
[@&#8203;tanstack/angular-query-experimental](https://togithub.com/tanstack/angular-query-experimental)[@&#8203;5](https://togithub.com/5).12.1

###
[`v5.12.0`](https://togithub.com/TanStack/query/compare/v5.10.0...v5.12.0)

[Compare
Source](https://togithub.com/TanStack/query/compare/v5.10.0...v5.12.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants