Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): implicit navigation for layout routes without a prefixed underscore id #1584

Merged

Conversation

SeanCassiere
Copy link
Contributor

Layout/pathless routes are denoted by an id property.

In file-based routing, an underscore is prefixed to this id, but it shouldn't be required.

So the approach for resolving the destination route when navigating without providing the from or to values needs to be changed to account for this.

@SeanCassiere SeanCassiere marked this pull request as ready for review May 11, 2024 03:20
Copy link

nx-cloud bot commented May 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ad450b8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere changed the title fix(react-router): implicit navigation for layout routes without an underscore prefixed id fix(react-router): implicit navigation for layout routes without a prefixed underscore id May 11, 2024
@SeanCassiere SeanCassiere merged commit 1ecb2bb into main May 11, 2024
7 checks passed
@SeanCassiere SeanCassiere deleted the fix-implicit-navigation-on-layouts-without-underscore-ids branch May 11, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant