Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-router): implicit navigation for layout routes without a prefixed underscore id #1584

Merged
merged 6 commits into from
May 11, 2024
Merged

fix(react-router): implicit navigation for layout routes without a prefixed underscore id #1584

merged 6 commits into from
May 11, 2024

Commits on May 11, 2024

  1. test: tests for layouts without an underscore id

    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    92d71ef View commit details
    Browse the repository at this point in the history

  2. test: correct the tests here

    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    2c0a931 View commit details
    Browse the repository at this point in the history

  3. fix: dont use the removeLayoutSegments and rework how this works

    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    d77e096 View commit details
    Browse the repository at this point in the history

  4. chore: remove @typescript-eslint/no-unnecessary-type-assertion from… 

    … router.ts
    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    5f2df89 View commit details
    Browse the repository at this point in the history

  5. chore: nuke the removeLayoutSegments function

    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    203f648 View commit details
    Browse the repository at this point in the history

  6. chore: stop eslint from freaking out

    @SeanCassiere
    SeanCassiere committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ad450b8 View commit details
    Browse the repository at this point in the history