Support static prefixes & suffixes in dynamic path segments #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed up some more of the conflicts. It looks like a few examples broke with this (infinite loops?). So we'll need to hold off on this. |
|
This would need to be updated with all of the new stuff, including file based route generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address #707 by adding support for routes of the form
prefix$var$suffix. This is technically a breaking change in that you can no longer have$in the name of a dynamic path segment param. I'm unsure if that is something people do. If it is concerning I can adjust this to only support prefixes which would not be a breaking change.I'm not familiar with the code base so I apologize if this is incomplete or broken. It seemed like there wouldn't be any changes needed to react-router as all the logic was in router-core. I wasn't sure if the cli needed changes.