Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static prefixes & suffixes in dynamic path segments #709

Closed
wants to merge 2 commits into from

Conversation

FugiTech
Copy link
Contributor

@FugiTech FugiTech commented Sep 1, 2023

This address #707 by adding support for routes of the form prefix$var$suffix. This is technically a breaking change in that you can no longer have $ in the name of a dynamic path segment param. I'm unsure if that is something people do. If it is concerning I can adjust this to only support prefixes which would not be a breaking change.

I'm not familiar with the code base so I apologize if this is incomplete or broken. It seemed like there wouldn't be any changes needed to react-router as all the logic was in router-core. I wasn't sure if the cli needed changes.

@tannerlinsley
Copy link
Collaborator

I fixed up some more of the conflicts. It looks like a few examples broke with this (infinite loops?). So we'll need to hold off on this.

@tannerlinsley
Copy link
Collaborator

This would need to be updated with all of the new stuff, including file based route generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants