Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: measureElement is not exposed anymore #610

Closed
2 tasks done
GilHelfgottGong opened this issue Oct 19, 2023 · 1 comment
Closed
2 tasks done

Breaking change: measureElement is not exposed anymore #610

GilHelfgottGong opened this issue Oct 19, 2023 · 1 comment

Comments

@GilHelfgottGong
Copy link

Describe the bug

I've upgraded from version 3.0.0-beta.58 to version 3.0.0-beta.9 and using the dynamic approach as described in the documentation: https://tanstack.com/virtual/v3/docs/examples/react/dynamic
Since upgrading, the measureElement ref that's in line 84 in the link provided is undefined.
This causes miscalculation of the elements' height.
Thanks!

Your minimal, reproducible example

https://tanstack.com/virtual/v3/docs/examples/react/dynamic

Steps to reproduce

https://tanstack.com/virtual/v3/docs/examples/react/dynamic : line 84, measureElement is undefined

Expected behavior

measureElement to work as in previous versions and measure the height of the elements.
Currently what I'm seeing is a mismatch between the actual height of the elements to the container size using getTotalSize()

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

OS: macOS
Browser: Chrome 118.0.5993.70

tanstack-virtual version

3.0.0-beta.9

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@piecyk
Copy link
Collaborator

piecyk commented Oct 19, 2023

@GilHelfgottGong there is small mismatch, latest version is v3.0.0-beta.66 till we sort it out you need to pin point the correct version.

@piecyk piecyk closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants