Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support: token error on response when the address is not compacted #81

Open
gromain opened this issue Jun 15, 2017 · 0 comments
Open

Comments

@gromain
Copy link

gromain commented Jun 15, 2017

Hello,

I'm opening this issue in link with #37 .
I commented over there, but it went unnoticed, and it's an unrelated problem.

I'll write down below what I posted over here.

I'm sorry for reopening this issue, but there is still a little bug.

It's when you do a request with a full IPv6 (example fd01:0000:0000:3ead:c5b2:bad0:6bb1:6dbf) but when the response received only gives back the shortened address (aka fd01::3ead:c5b2:bad0:6bb1:6dbf).

I believe the trouble starts here (or end here ;-) ), line 108 in messagelayer.py, function receive_response. This function hashes the tuple (host, port, response.mid), with the data received in the response, and then tries to compare it with the hash made in the function send_request, in the same file at line 216.

So I believe the function parse_uri (here) could be modified to include a contraction of the consecutive 0 in IPv6 addresses.

@gromain gromain changed the title IPv6 support: IPv6 support: token error on response when the address is not compacted Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant