-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad descripition of the arming settings choices #1024
Comments
Good catch. The switch option is a recent addition and nothing about the text was updated to follow that. As a separate question, should we only make the switch mode arm while throttle is low? This would seem safer, but if people try and fly 3D they might want to arm with the throttle at mid stick... |
Maybe check for low throttle for standard flight and check near-zero throttle for 3D flight. Or prevent user flying 3D to choose "Throttle off and Switch". |
This change is not as straightforward as it seems since the values on the combobox are fetched from the uavo definition. |
As a short term fix it can be enough, but adding a mode with a check is a must-have IMHO. |
On the GCS, under Input > Arming Settings tab, the description "Arm airframe using throttle off and: [Choice here]" is confusing if you consider the choice "Switch". When using the switch for arming, no throttle down verification is done and it's possible to arm the airframe with full throttle.
IMHO, the best solution should be to change the description to : "Arm airframe using: [Choice here]" and to modify the choices to be :
"Switch only" would not check is throttle is off while "Throttle off and Switch" would.
Both Switch choices should allow to disarm motors even if throttle is not off, I think it is a good safety feature.
The text was updated successfully, but these errors were encountered: