Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotary Encoder plugin: Add a drop-down list with EncoderType #470

Open
vzahradnik opened this issue May 6, 2024 · 2 comments
Open

Rotary Encoder plugin: Add a drop-down list with EncoderType #470

vzahradnik opened this issue May 6, 2024 · 2 comments

Comments

@vzahradnik
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
TcMenu defines the following enum for the rotary encoder type.
image

The plugin in TcMenu Designer, however, doesn't list all the options. HALF_CYCLE is missing and FULL_CYCLE is implicit.

image

Describe the solution you'd like
Instead of having a checkbox titled Quarter cycle encoder, add a new drop-down list with all encoder type options, defaulting to FULL_CYCLE.

@davetcc
Copy link
Collaborator

davetcc commented May 29, 2024

Agreed that would be better, I'll look at this, but the issue is that existing users could be quite badly affected by the change as their properties may no longer align, and it would default to the wrong value.

As per offline discussion earlier, I think that we should get the state-machine based encoder working first, and then maybe even create an entirely new plugin item for it. Marking this one as deprecated or similar.

@vzahradnik
Copy link
Collaborator Author

Yes, I agree. It is not a blocker because users can set this option in the code. This is what I did when I tested the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants