Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structopt is in maintenance mode, see clap for new development #525

Open
epage opened this issue Feb 8, 2022 · 5 comments
Open

structopt is in maintenance mode, see clap for new development #525

epage opened this issue Feb 8, 2022 · 5 comments

Comments

@epage
Copy link
Contributor

epage commented Feb 8, 2022

structopt is a derive wrapper around clap v2. As of clap v3, the derive wrapper is included with clap under the derive feature flag. A migration guide is available for users wishing to switch.

Both clap v2 and structopt are in maintenance mode. They both depend on ansi_term which is unmaintained.

I've seen users posting here and elsewhere who are unaware of the migration. Dependabot, cargo outdated, and cargo upgrade won't report anything.

@epage
Copy link
Contributor Author

epage commented Feb 8, 2022

Brainstorming:

  • Pin an issue about the maintenance status
  • See if rustsec can add this to their warnings discouraging some crates in favor of others
    • The focus here is on "no maintainer" (no one available in case of vulnerability) so it'd be stretching things
  • Move this repo into the clap repo
  • Add #[deprecated] attributes to the trait methods
  • Have the derive inject a deprecated function and a call to it

@TeXitoi
Copy link
Owner

TeXitoi commented Feb 9, 2022

  • I'm not sure an pinned issue would change anything
  • Not sure that's rustsec job, there is no vulerability known in clap v2 for a long time, so no much risk.
  • Same, moving the structopt repo will not change.
  • Deprecation is annoying.

But maybe the interesting part is that cargo outdated and friend don't report anything. Maybe I can publish a structopt v0.4 (or v1?) that is empty and point to clap v3, for easy discoverability?

@epage
Copy link
Contributor Author

epage commented Feb 9, 2022

Yeah. didn't call that out but it seems like it'd be nice to have a database for cargo outdated that fills a purpose besides rustsec.

If you are up for a dummy release, that works too.

@TeXitoi TeXitoi pinned this issue Feb 9, 2022
@TeXitoi
Copy link
Owner

TeXitoi commented Feb 9, 2022

This issue is now pinned, not sure it will change anything, but that's free :-)

@epage epage changed the title How do we raise the visibility of the structopt -> clap change? structopt is in maintenance mode, see clap for new development Mar 25, 2022
@pinkforest
Copy link

pinkforest commented Sep 2, 2022

We could always flag informational = unmaintained on structopt if @TeXitoi agrees ?

We flag informational advisories routinely to deprecate or handle superceded crates when the maintainer asks us to do so.

Note ansi_term was deprecated so we've had to include structopt/clap2 specific advice there.

@epage epage mentioned this issue Dec 7, 2022
5donuts added a commit to 5donuts/tilr that referenced this issue Jul 4, 2023
StructOpt is in maintenance mode (see:
TeXitoi/structopt#525).
tamird added a commit to tamird/git2-rs that referenced this issue Jan 7, 2024
See TeXitoi/structopt#525.

Currently git2 is the second most downloaded dependent of structopt:
https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/rust-base64 that referenced this issue Jan 7, 2024
tamird added a commit to tamird/rust-base64 that referenced this issue Jan 7, 2024
tamird added a commit to tamird/codespan that referenced this issue Jan 8, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/codespan that referenced this issue Jan 8, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/codespan that referenced this issue Jan 8, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/codespan that referenced this issue Jan 8, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/codespan that referenced this issue Jan 8, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/git2-rs that referenced this issue Jan 11, 2024
See TeXitoi/structopt#525.

Currently git2 is the second most downloaded dependent of structopt:
https://crates.io/crates/structopt/reverse_dependencies.
tamird added a commit to tamird/git2-rs that referenced this issue Jan 11, 2024
tamird added a commit to tamird/git2-rs that referenced this issue Jan 15, 2024
tamird added a commit to tamird/codespan that referenced this issue Feb 22, 2024
See TeXitoi/structopt#525.

Currently codespan-reporting is the second most downloaded dependent of
structopt: https://crates.io/crates/structopt/reverse_dependencies.
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec-tool that referenced this issue Mar 18, 2024
According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.

 * Migrate to clap so that nightly builds succeed as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm added a commit to tgonzalezorlandoarm/parsec that referenced this issue Mar 18, 2024
According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.

Migrate to clap so that nightly builds succeed as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm added a commit to parallaxsecond/parsec that referenced this issue Mar 18, 2024
According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.

Migrate to clap so that nightly builds succeed as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm added a commit to parallaxsecond/parsec-tool that referenced this issue Mar 18, 2024
According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.

 * Migrate to clap so that nightly builds succeed as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants