Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when Generating New Chunks in a World #1049

Closed
Wealthyturtle opened this issue Nov 14, 2016 · 7 comments
Closed

Crash when Generating New Chunks in a World #1049

Wealthyturtle opened this issue Nov 14, 2016 · 7 comments

Comments

@Wealthyturtle
Copy link

Wealthyturtle commented Nov 14, 2016

Affected Mod Versions:

Mekanism, MrTJPCore

  • Forge version: 10.13.4.1614
  • RTG version: 1.1.1.2
Issue Description:

(Please provide screenshots if neccessary/possible. Images can be dragged & dropped into this window.)
Crash when Generating New Chunks in a World.
(Note: This May Not be Realistic Terrain Generation's Fault, but it was Referenced in the Crash Report. This May be Caused by MrTJPCore / Mekanism)

Steps to reproduce the issue: (If it's easily reproducible.)
  1. Generate New Chunks in an Existing World in a Multiplayer Server
Extra Information:

Crash Log:
http://pastebin.com/4JsJKAY1

Issue in MrTJPCore's Issues: MrTJP/MrTJPCore#20
Issue in Mekanism's Issues: mekanism/Mekanism#3975

@whichonespink44
Copy link
Member

Since you're using 1.1.1.2, this is not likely an RTG issue, as we recently put in 'graceful failing' for structure generation. This means that instead of crashing during structure generation, RTG will just stop generating the structure at the point of failure, allowing the world to carry on generating.

If this turns out to not be the case, please let us know so we can investigate further.

@srs-bsns
Copy link
Member

srs-bsns commented Nov 14, 2016

This is caused (AGAIN) by Minecraft's non-threadsafe Hashmap iteration while the Mekanism salt generator is trying to generate salt at the same time that RTG is trying to place a structure, likely a village part, in the same chunk.

@whichonespink44 I can't remember, did you backport our crash prevention from 1.10.2 for this sort of thing? It would likely work good in cases like this, and the worst case scenario would be an unfinished structure placement, but a rare ugly/unfinished village structure is better than a crash, IMO.

membercmes

Edit: Ninja'd again

@whichonespink44
Copy link
Member

Forgot to mention... if you want a faster resolution to this issue, try reproducing the crash with as few mods as possible and posting that crash report as well. The crash report in the OP has a lot of mods, so unless one of the other authors knows immediately why it's crashing, they're not going to be able to reproduce it themselves with that many mods. And if we can't reproduce it, we can't fix it.

Let us know how it goes.

@whichonespink44
Copy link
Member

Double ninja'd!! xD

@Cronosus
Copy link

Cronosus commented Dec 5, 2016

not relevant to OP, but i have today crash too on generating world, and i found problem on generating of some biomes.. not generated structures and trees, jut dirt biomes (example: http://cronos.wz.cz/mc/2016-12-05_21.28.24.png)..
i use BoP and biometweaker, and other mods..

crash here: http://cronos.wz.cz/mc/crash-2016-12-05_21.22.48-server.txt

@srs-bsns
Copy link
Member

srs-bsns commented Dec 5, 2016

@srs-bsns
Copy link
Member

Closing this as there isn't much more we can do to prevent CMEs like this in 1.7.10 as it is a crash with how Minecraft works. CMEs like this don't appear to happen in new versions of Minecraft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants