Fix NullPointerException thrown on deleting folders outside storage #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TeamAmaze#1102. Deleting folders outside storage area is still not possible (either with or without root) after this change, but you'll get an error Toast instead of an app crash. - Code cleanups at FileUtil: remove rmdir1() and deleteFilesInFolder() - Fix FileUtil.rmdir() - Fix DeleteTask, display error Toast on problem during deleting folder
|
It shouldn't try to delete the file if root is not enabled. Showing an error is fine enough. |
VishalNehra
approved these changes
Mar 21, 2018
|
Will make a pull request later, with some corrections. |
Corrected file deletion bugs and renamed vars in DeleteTask & FileUtil
EmmanuelMess
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102. Deleting folders outside storage area is still not possible (either with or without root) after this change, but you'll get an error Toast instead of an app crash.
I'm still not sure if I should fix deleting folders outside storage with root (currently calls to
HybridFile.delete()never seen went toRootUtils.delete()) as it is dangerous. That will be in another PR anyway.Changes: