Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not receive sundamage in dark underwater places #161

Closed
maxanier opened this issue Apr 24, 2017 · 1 comment
Closed

Should not receive sundamage in dark underwater places #161

maxanier opened this issue Apr 24, 2017 · 1 comment
Labels
enhancement Any minor tweak that can be introduced in minor releases

Comments

@maxanier
Copy link
Member

Vampires should not receive sundamage when far down underwater.
@maxanier maxanier added the enhancement Any minor tweak that can be introduced in minor releases label Apr 24, 2017
maxanier added a commit that referenced this issue Apr 25, 2017
@maxanier
Fixes #161.
01889f2
maxanier added a commit that referenced this issue Apr 25, 2017
@maxanier
Fixes #161 for 1.10
f197483 
(cherry picked from commit 01889f2)
@maxanier
Copy link
Member Author

Will be included in Vampirism Version 1.2.

Due to performance optimization the new check is only done if the player is below sea level. Above sea level a single block of water is sufficient to block sun damage entirely.
Below sea level the number of water blocks between sea level and player is now calculated, if higher than a configurable threshold value (balance_vampire_player/sundamage_water_blocks) no sundamage will be applied.

@maxanier maxanier closed this as completed May 7, 2017
maxanier added a commit to maxanier/Vampirism that referenced this issue Oct 23, 2020
@maxanier
Fixes TeamLapen#161.
004da99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any minor tweak that can be introduced in minor releases
Projects
Vampirism
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxanier