Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use IP to select app's language #1130

Closed
2 tasks done
aladar42 opened this issue Feb 20, 2018 · 6 comments · Fixed by #2921
Closed
2 tasks done

Do not use IP to select app's language #1130

aladar42 opened this issue Feb 20, 2018 · 6 comments · Fixed by #2921
Labels
bug Issue is related to a bug feature request Issue is related to a feature in the app localisation / translation Everything that has to do with translations or Weblate requires extractor change This issue requires a change to the extractor

Comments

@aladar42
Copy link
Contributor

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

Currently it seems NewPipe uses the IP to determine the language of the app. This is pretty sub-optimal for any user that uses an out-of-country VPN, or for users who wish to use another language (I set all my applications to English, for example). It's also harder to debug translations thi way. Could it be made so that it either has a language selector, or selects the language depending on the system locale?

@theScrabi
Copy link
Member

Thats actually a problem. You can select the content country but not the language. Tho its not that hard to implement. We need to do this.

@theScrabi theScrabi added bug Issue is related to a bug feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor labels Feb 21, 2018
@rattan77
Copy link

My app language changed to Malay as I am in Malaysia. It is super annoying. Wonder if I was in Germany , the language will change to German ? lol

@theScrabi
Copy link
Member

theScrabi commented Feb 21, 2018

Well I will have problems with this soon as well, so you can look forward for a fix.

@Koitharu
Copy link
Contributor

Koitharu commented Sep 1, 2018

I already work on it

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@Stypox
Copy link
Member

Stypox commented Jul 18, 2019

Related: #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug feature request Issue is related to a feature in the app localisation / translation Everything that has to do with translations or Weblate requires extractor change This issue requires a change to the extractor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants