Add language selector to change the app language

[B0pol]

• I carefully read the contribution guidelines and agree to them.

Fixes #2794, fixes #2162, fixes #2887, fixes #1215, fixes #1130, fixes #2848, fixes #578, fix r/NewPipe : Any way to change the app language? & r/NewPipe : how to change app language ?

Explaination :
Before, NewPipe's language was phone's language. Now, it's the language selected in Settings -> Content -> App language, and by default, it stays system default language.
Thus, you can force an app language (eg. English for developing / debugging : take a screenshot in English) or use non-available system language (Esperanto isn't translated for Android) or simply just set the language you want without changing phone / system language.

APK: 2020-01-27_language-selector#2921_APK.zip

[B0pol]

I found out what does content language, it's used by NewPipe Extractor.

Then think we should use a third selector that would only change the language of NewPipe.

I think that would be implemented like that :

where we would set the language already translated in NewPipe, + at the top a button that would be : system language.

I'll work on it this week

[B0pol]

I found an exception (#2940), but it's not related to my PR, it's related to the formatter and %1$s not in the good order and arabic alphabet.

[B0pol]

I changed the way time is displayed, it now use NewPipe's language (the new selector), previously it was only systems's language.
This fixes #1215 . In the limit of the languages of the library Pretty time we use : https://www.ocpsoft.org/prettytime/#section-12

[B0pol]

Here are some screenshots :
System language was Spanish

[B0pol]

I just fixed Indonesian that wasn't possible to select by renaming values-id to values-in, but also wasn't possible to use with device language. Indonesian was 99% translated but unusable.
Briefly, android use outdated version of an iso norm, then it doesn't recognize id, but in.
See https://stackoverflow.com/questions/13291578/how-to-localize-an-android-app-in-indonesian-language.
I also added Occitan to the selector.
So the selector is working for every language now.
Pirate will show English as values-pr/strings.xml is empty, and for some languages you will see a lot of english, as it's not translated much (I'm thinking to Interlingua, Occitan…)

[B0pol]

@abusarimhindi APK: apk-debug
In settings, you can change for Urdu in settings / content settings / NewPipe's language.

For anyone else wondering, this is a TEST version: there might be some problems, because I was based on dev branch in extractor, and I switched to master branch of extractor (the only one that includes the fix for decryption bug). That's also why I didn't commit these changes.

I manually updated extractor version so that YouTube works again, and remove the urdu string, took the one from weblate.

[B0pol]

This is 0.18.1 because I'm based on debug build, which is still on 0.18.1.
But as I said, I manually updated extractor version, to prevent the decryption crash, and I manually updated urdu strings from weblate, just for you, and I didn't commit these changes because this should be fixed by updating dev branch, not by fixing manually

But I think you have the wrong version, you have to take the app-debug that I gave in my last comment, or just use this link https://github.com/TeamNewPipe/NewPipe/files/4108063/app-debug.zip

[abusarimhindi]

This is 0.18.1 because I'm based on debug build, which is still on 0.18.1.
But as I said, I manually updated extractor version, to prevent the decryption crash, and I manually updated urdu strings from weblate, just for you, and I didn't commit these changes because this should be fixed by updating dev branch, not by fixing manually

Sorry, It is Ok. Firstly I downloaded the old file, now updated. Thanks again.

[TobiGr]

Code looks good so far. Just some minor comments.

Is it necessary to call changeAppLanguage() in all onCreate and onResume methods or can we just do it in App.java in? If not, it might be good to add a new method and call it instead of changeAppLanguage() with the same parameters again and again to increase maintainability.

public static void assureCorrectAppLanguage() {
    changeAppLanguage(getAppLocale(getApplicationContext()), getResources());
}

[B0pol]

public static void assureCorrectAppLanguage() {
    changeAppLanguage(getAppLocale(getApplicationContext()), getResources());
}

I can't do that, I can't have context and resources from a static context.
The most optimized thing I can have is

public static void assureCorrectAppLanguage(Context c) {
    changeAppLanguage(getAppLocale(c), c.getResources());
}

and then, in mainactivity and other activites needing it:
assureCorrectAppLanguage(this);

Is it necessary to call changeAppLanguage() in all onCreate and onResume methods or can we just do it in App.java in?

Yesn't sir! If you put in onCreate and onResume of mainActivity, it will work for about 95%. (And putting it in App.java does nothing) I'll say why I put for the other files:

• AboutActivity: everything is fine because strings are loaded on runtime, except title which is set in manifest.xml, so I changed it on runtime
• Player: kinda tough, it is in the language you want, except if you press a button, change orientation (landscape / portrait).
• PlaybackParameterDialog: it was showing wrong language without it.
• The other file honestly I don't remember, but at first I put in MainActivity, and while testing phase I added where it would show the wrong language.

It's kinda like the ThemeHelper.setTheme(this, ServiceHelper.getSelectedServiceId(this));: you don't need everywhere, but in activities who are making problems without it.

[TobiGr]

public static void assureCorrectAppLanguage() {
    changeAppLanguage(getAppLocale(getApplicationContext()), getResources());
}

I can't do that, I can't have context and resources from a static context.
The most optimized thing I can have is

public static void assureCorrectAppLanguage(Context c) {
    changeAppLanguage(getAppLocale(c), c.getResources());
}

My bad. This happens when you write reviews during lectures :D

[TobiGr]

Code looks go so far. I'll test it as soon as possible

[B0pol]

Just one thing you should know
I made changes to values-ur/strings.xml, because of formatter crash (#2940)
They were fixed by weblate in the meantime, so either you update dev with weblate soon and I solve conficts before you merge the pr, or for every future conflicts existing with Urdu strings, you should pick the Weblate version.

My bad. This happens when you write reviews during lectures :D

No problem

[TobiGr]

I made changes to values-ur/strings.xml, because of formatter crash (#2940)
They were fixed by weblate in the meantime, so either you update dev with weblate soon and I solve conficts before you merge the pr, or for every future conflicts existing with Urdu strings, you should pick the Weblate version.

I merged weblate into dev. Could you take a look at the conflicts? I am short on time until I finished my exams. Thanks :)

[B0pol]

I merged weblate into dev. Could you take a look at the conflicts? I am short on time until I finished my exams. Thanks :)

Done. Actually, the only conflict shown on Github was the indonesian file which have been renamed, but while merging with git I had no problem.

I think the PR is finally fully ready.

[TobiGr]

Thanks. One small thing. Can you please integrate this setting into the mechanism which displays a toast that language changes require an app restart?

NewPipe/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java

Lines 135 to 140 in c5e6bb5

	if (!selectedLocalization.equals(initialSelectedLocalization)
	|| !selectedContentCountry.equals(initialSelectedContentCountry) || !selectedLanguage.equals(initialLanguage)) {
	Toast.makeText(requireContext(), R.string.localization_changes_requires_app_restart, Toast.LENGTH_LONG).show();
	NewPipe.setupLocalization(selectedLocalization, selectedContentCountry);
	}

[B0pol]

Thanks. One small thing. Can you please integrate this setting into the mechanism which displays a toast that language changes require an app restart?

NewPipe/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java

Lines 135 to 140 in c5e6bb5

	if (!selectedLocalization.equals(initialSelectedLocalization)
	|| !selectedContentCountry.equals(initialSelectedContentCountry) || !selectedLanguage.equals(initialLanguage)) {
	Toast.makeText(requireContext(), R.string.localization_changes_requires_app_restart, Toast.LENGTH_LONG).show();
	NewPipe.setupLocalization(selectedLocalization, selectedContentCountry);
	}

done

[TobiGr]

Thanks!