Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op7/Android 10 This permission is needed to open in popup mode. #2922

Closed
1 task done
famewolf opened this issue Jan 5, 2020 · 4 comments
Closed
1 task done

Op7/Android 10 This permission is needed to open in popup mode. #2922

famewolf opened this issue Jan 5, 2020 · 4 comments
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface

Comments

@famewolf
Copy link

famewolf commented Jan 5, 2020

One a oneplus 7 Pro running the latest Android 10 international firmware if set to minimize to the popup player when you hit home a small message appears over the home button saying "This permission is needed to open in popup mode" but it doesn't identify what permission. Additionally I went into the permissions for Newpipe and the only one available is Storage which has already been allowed. I assume you need permission to overdraw screens but it doesn't say that nor give me opportunity to enable it. Since the app did not crash I didn't include that. Reasonably certain it's either an oxygenos or Android 10 issue but figured I would provide the heads up.

Additionally when I chose the option to play in background it worked after a brief pause in the music however even after the song ended newpipe continued to cause excessive battery drain until Oxygenos flagged it and prompted me to force kill it.

Screenshot_20200104-232707

@famewolf
Copy link
Author

famewolf commented Jan 5, 2020

I did eventually resolve this by finding the permission to display over other apps and enabling newpipe there but in other occasions it's taken me exactly to where I needed to enable it. I'll leave this open due to that but feel free to close if not of interest.

@Stypox Stypox added bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface labels Jan 5, 2020
@harshlele
Copy link
Contributor

I think the reason it doesn't send you to the settings is because the user is exiting the app, so forcefully sending them to the settings wouldn't be good.
One way this could be solved is to get the permission from the user right when the setting is enabled.

@harshlele
Copy link
Contributor

@Stypox this happens on my device(Nokia 6.1) running Android 10 too, so i dont think its device specific. I tested it on a Android 6 emulator and there when you press the home button, it shows that toast, then takes you to the settings window, but then when you give it permission, it doesnt actually open the popup. I think this happens on any device running android 6 and above.
I still think the permission should be asked when the user actually sets it to popup when home is pressed.

@TobiGr
Copy link
Member

TobiGr commented Feb 1, 2020

Fixed by #3004

@TobiGr TobiGr closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

4 participants