Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reduce thumbnail resolution #3121

Closed
AlbahrawyTiger opened this issue Feb 21, 2020 · 12 comments · Fixed by #10062
Closed

Add option to reduce thumbnail resolution #3121

AlbahrawyTiger opened this issue Feb 21, 2020 · 12 comments · Fixed by #10062
Labels
feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor

Comments

@AlbahrawyTiger
Copy link

It consumes a lot of data to download the video and thumbnails page. Please put an option to reduce the quality of the thumbnails

@gkeegan
Copy link
Contributor

gkeegan commented Feb 21, 2020

Please change issue name to "Add option to reduce thumbnail resolution" or similar. I'm not entirely sure that doing this is possible, since I don't know if YouTube provides different sizes. In the meantime, you can try disabling loading thumbnails entirely.

@Stypox
Copy link
Member

Stypox commented Feb 21, 2020

@gkeegan YouTube provides different sizes, but the extractor only extracts the one with the highest resolution

@TobiGr TobiGr added requires extractor change This issue requires a change to the extractor good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Feb 21, 2020
@TobiGr
Copy link
Member

TobiGr commented Feb 21, 2020

I though about this while working on the extraction of the new YouTube version, too. I think we should extract all thumbnails and let the client decide which thumbnail to load.

@wb9688
Copy link
Contributor

wb9688 commented Feb 21, 2020

@TobiGr: I was just about to reply the same thing.

@B0pol
Copy link
Member

B0pol commented Feb 21, 2020

About PeerTube extractor

This line give the highest quality.

For lower quality, use thumbnailPath instead.
Also, on this line, it doesn't give the max resolution. previewPath gives higher resolution.

But, list items don't need high quality, it's already showing fine, at least on mobile.
I changed only for video detail, because it's really visible: low quality | high quality.

Idea

I think we should change Load thumbnails setting, from a ON/OFF switch, to a list:

  • highest resolution: it would typically be used for TV, tablets, or other big screens.
  • optimized resolution (DEFAULT): it would get the max resolution for the things that need it, for example the thumbnail in video detail page would be max res, but in list it wouldn't be max res (for YouTube there are 4 thumbnails if I remember, then 2 or 3 / 4). Typically be used by phones, and set as default setting.
  • lowest resolution.
  • thumbnails disabled.

More settings (for example choose the exact resolution for YouTube from the 4 available) would make this setting an airplane cockpit.

@AlbahrawyTiger AlbahrawyTiger changed the title It consumes a lot of data to download the video and thumbnails page. Add option to reduce thumbnail resolution Feb 23, 2020
@AlbahrawyTiger AlbahrawyTiger changed the title Add option to reduce thumbnail resolution Add option to reduce thumbnail resolution Plenty of data is used to load the video page Feb 23, 2020
@AlbahrawyTiger
Copy link
Author

Not only is the problem with thumbnails, but when thumbnails are disabled, a lot of data is still used to load the video page itself

@Stypox
Copy link
Member

Stypox commented Feb 23, 2020

That can't be reduced, it's just the page size provided by YouTube, so we can't change it...

@B0pol
Copy link
Member

B0pol commented Feb 29, 2020

That can't be reduced, it's just the page size provided by YouTube, so we can't change it...

In fact, it can with pbj=1 parameter. See TeamNewPipe/NewPipeExtractor#261 (comment) and TeamNewPipe/NewPipeExtractor#262.

@wb9688
Copy link
Contributor

wb9688 commented Feb 29, 2020

With pbj=1, pages will be more like 20-30 KB gzipped.

@Stypox
Copy link
Member

Stypox commented Feb 29, 2020

In fact, it can with pbj=1 parameter. See TeamNewPipe/NewPipeExtractor#261 (comment) and TeamNewPipe/NewPipeExtractor#262.

Yeah, now I've seen @wb9688's improvements, 6 days ago I didn't ;-)
Also, this issue was probably about pre-0.18.5.
@AlbahrawyAlalimi fixed in next version

@wb9688
Copy link
Contributor

wb9688 commented Feb 29, 2020

@Stypox: The thumbnail stuff isn't fixed in the next version though. I'll fix that on the NewPipeExtractor-side soon™ though

@AlbahrawyTiger
Copy link
Author

Version 0.18.7 and still takes more than 1MB to download the video page with thumbnails disabled!

@triallax triallax changed the title Add option to reduce thumbnail resolution Plenty of data is used to load the video page Add option to reduce thumbnail resolution Jun 13, 2021
@SameenAhnaf SameenAhnaf added the feature request Issue is related to a feature in the app label Feb 23, 2023
@Stypox Stypox removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants