Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping fonts #5096

Closed
4 tasks done
KatoriYuu opened this issue Dec 4, 2020 · 13 comments · Fixed by #5813
Closed
4 tasks done

Overlapping fonts #5096

KatoriYuu opened this issue Dec 4, 2020 · 13 comments · Fixed by #5813
Assignees
@wangear
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@KatoriYuu
Copy link

KatoriYuu commented Dec 4, 2020 •
edited
Loading

Checklist

Steps to reproduce the bug

Use the largest font size in Android setting.

Actual behaviour

Texts are overlapped.

Expected behavior

Everything works correctly.

Screenshots/Screen recordings

Screenshot_20201204-202824

Logs

Device info

  • Android version/Custom ROM version: Android 10, Stock ROM.
  • Device model: Nokia 8.1
@KatoriYuu KatoriYuu added the bug Issue is related to a bug label Dec 4, 2020
@KatoriYuu
Copy link
Author

The same issue was reported in the past. However it was caused by using a custom font. I think that the solution is displaying the title of videos in only 1 line if the font size is too large. Another way is adding an option to customize the font size in app.

@triallax triallax added the GUI Issue is related to the graphical user interface label Dec 5, 2020
@triallax triallax mentioned this issue Dec 27, 2020
Closed
@B0pol B0pol mentioned this issue Dec 27, 2020
Closed
@AudricV AudricV mentioned this issue Mar 12, 2021
Closed
4 tasks
@wangear
Copy link
Contributor

wangear commented Mar 12, 2021

Hello! I'd like to work on this enhancement. Can i assigned to this issue? :)

@wangear
Copy link
Contributor

wangear commented Mar 12, 2021

I think that the solution is converting sp to dp.

@AudricV
Copy link
Member

AudricV commented Mar 12, 2021 •
edited
Loading

Can i assigned to this issue? :)

Done ;)

wangear added a commit to wangear/NewPipe that referenced this issue Mar 12, 2021
@wangear
Overlapping fonts TeamNewPipe#5096
12d9cf0 
issue : TeamNewPipe#5096
changed : sp -> dp
@wangear wangear mentioned this issue Mar 12, 2021
Merged
5 tasks
@TobiGr TobiGr linked a pull request Mar 12, 2021 that will close this issue
Overlapping fonts #5096 #5813
Merged
5 tasks
wangear added a commit to wangear/NewPipe that referenced this issue Mar 13, 2021
@wangear
Overlapping fonts TeamNewPipe#5096
b5ce2eb 
issue : TeamNewPipe#5096
changed :
- rollback dp->sp.
- If additional textView is overlapped, only title view shows.
@TacoTheDank
Copy link
Member

@wangear Could you provide a built debug APK with these changes so that @KatoriYuu can test them to see if it now works?

@AudricV
Copy link
Member

AudricV commented Mar 22, 2021

@TacoTheDank The CI is here for APKs: https://github.com/TeamNewPipe/NewPipe/suites/2249030764/artifacts/46755391

@wangear
Copy link
Contributor

wangear commented Mar 22, 2021

@TiA4f8R Thank you

@KatoriYuu
Copy link
Author

@wangear Hi, I have tried the debug version. However, the problem with channels card still persists. I can see that your solution is hiding the view counter to make more space for title, which I think is not really convenient. Can you try to solve this in some other ways? I would prefer increasing the height of every card, or if it's not possible, I'm fine with displaying the title in one line, too.
Screenshot_20210323-065154

@wangear
Copy link
Contributor

wangear commented Mar 23, 2021

@KatoriYuu the problem with channels card still persists -> Sorry. I'll fix it.
I can see that your solution is hiding the view counter to make more space for title ->
I checked the height of view and if each view overlapped (not word, just view), then I hide the count.
Because every Language has different height, so it is hard to check exactly.
I would prefer increasing the height of every card, or if it's not possible, I'm fine with displaying the title in one line, too.
-> I will think about it.
Thank you for advise.

@TacoTheDank
Copy link
Member

TacoTheDank commented Mar 23, 2021 •
edited
Loading

@TacoTheDank The CI is here for APKs: https://github.com/TeamNewPipe/NewPipe/suites/2249030764/artifacts/46755391

I forgot 😅 still getting used to the switch to github actions

@wangear
Copy link
Contributor

wangear commented Mar 23, 2021

@KatoriYuu
How about this?
Screenshot_20210323-103109_NewPipe Debug

I think that thumbnail position is better in the middle how about you?
any ideas?

@KatoriYuu
Copy link
Author

@wangear Wow, that looks great. I agree with you, the thumbnail should be placed in the middle.

@wangear
Copy link
Contributor

wangear commented Mar 23, 2021

@KatoriYuu All right. Thank you.

wangear added a commit to wangear/NewPipe that referenced this issue Mar 23, 2021
@wangear
Overlapping fonts TeamNewPipe#5096
fb02db7 
issue : TeamNewPipe#5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.
wangear added a commit to wangear/NewPipe that referenced this issue Mar 23, 2021
@wangear
Overlapping fonts TeamNewPipe#5096
bd25eff 
issue : TeamNewPipe#5096
changed :
- remove unusable variable
Stypox pushed a commit that referenced this issue Mar 31, 2021
@wangear
Fix overlapping fonts and crash on tapping anywhere on video after lo…
73cfa54 
…ng-pressing 'Popup' button (#5813)

* Overlapping fonts #5096
issue : #5096

* Overlapping fonts #5096
issue : #5096
changed :
- If additional textView is overlapped, only title view shows.

* Overlapping fonts #5096
issue : #5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.

* Overlapping fonts #5096
issue : #5096
changed :
- remove unusable variable

* Crash on tapping anywhere on video after long-pressing 'Popup' button #5804
issue : #5804
changed :
- checked null
- fixed NullPointerException.
tossj pushed a commit to tossj/NewPipe-legacy that referenced this issue Apr 23, 2021
@wangear @tossj
Fix overlapping fonts and crash on tapping anywhere on video after lo…
e29d0c3 
…ng-pressing 'Popup' button (TeamNewPipe/NewPipe#5813)

* Overlapping fonts TeamNewPipe/NewPipe#5096
issue : TeamNewPipe/NewPipe#5096

* Overlapping fonts TeamNewPipe/NewPipe#5096
issue : TeamNewPipe/NewPipe#5096
changed :
- If additional textView is overlapped, only title view shows.

* Overlapping fonts TeamNewPipe/NewPipe#5096
issue : TeamNewPipe/NewPipe#5096
changed :
- Remove treeObserve and hiding logic.
- RelativeLayout -> ConstraintLayout.
- layout size fixed -> wrap_content.
- if text size is bigger, layout height bigger too.

* Overlapping fonts TeamNewPipe/NewPipe#5096
issue : TeamNewPipe/NewPipe#5096
changed :
- remove unusable variable

* Crash on tapping anywhere on video after long-pressing 'Popup' button TeamNewPipe/NewPipe#5804
issue : TeamNewPipe/NewPipe#5804
changed :
- checked null
- fixed NullPointerException.
@MeHimWho MeHimWho mentioned this issue Oct 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangear wangear

Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overlapping fonts #5096 wangear/NewPipe
5 participants
@wangear @triallax @TacoTheDank @KatoriYuu @AudricV