Crash on tapping anywhere on video after long-pressing 'Popup' button #5804

jarp0l · 2021-03-10T09:27:55Z

Checklist

I am using the latest version - 0.20.11
I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Open any video (play it or pause it, doesn't matter).
Long-press (press and hold) the 'Popup' button, 'Enqueued' dialog appears.
Tap anywhere on video.

Actual behaviour

The app immediately crashes and displays crash log.

The app still crashes when you:

play next video and tap anywhere on the video.
go to Downloads by long-pressing the Download button, then come back to the video and like above tap anywhere on the video.

Expected behavior

Tapping anywhere on the video should display the controls (Play/Pause and others) rather than crashing.

Screenshots/Screen recordings

Logs

Exception

User Action: ui error
Request: App crash, UI failure
Content Country: US
Content Language: en-US
App Language: en_US
Service: none
Version: 0.20.11
OS: Linux Android 10 - 29

Crash log

java.lang.NullPointerException
	at org.schabi.newpipe.player.event.BasePlayerGestureListener.onDownInPopup(BasePlayerGestureListener.kt:232)
	at org.schabi.newpipe.player.event.BasePlayerGestureListener.onDown(BasePlayerGestureListener.kt:222)
	at android.view.GestureDetector.onTouchEvent(GestureDetector.java:661)
	at org.schabi.newpipe.player.event.BasePlayerGestureListener.onTouchInPopup(BasePlayerGestureListener.kt:108)
	at org.schabi.newpipe.player.event.BasePlayerGestureListener.onTouch(BasePlayerGestureListener.kt:82)
	at android.view.View.dispatchTouchEvent(View.java:14372)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3857)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3535)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3863)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:3492)
	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:733)
	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1922)
	at android.app.Activity.dispatchTouchEvent(Activity.java:4051)
	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69)
	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69)
	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:691)
	at android.view.View.dispatchPointerEvent(View.java:14644)
	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6526)
	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6313)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5751)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5804)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5770)
	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5926)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5778)
	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5983)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5751)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5804)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5770)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5778)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5751)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8910)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8771)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8724)
	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9046)
	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:194)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:336)
	at android.os.Looper.loop(Looper.java:197)
	at android.app.ActivityThread.main(ActivityThread.java:7948)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1075)

The text was updated successfully, but these errors were encountered:

iamthesenate1 · 2021-03-10T19:01:48Z

Can reproduce on Redmi Note 5A, Android 7.1.2

jarp0l · 2021-03-11T02:41:15Z

Reproduced only on v0.20.10 and 0.20.11, but not on 0.20.8 and 0.20.9.

wangear · 2021-03-11T14:47:14Z

Hello! I'd like to work on this enhancement. Can i assigned to this issue? :)

wangear · 2021-03-30T13:55:31Z

Hello. Can I assigned to this issue?

ShareASmile · 2021-03-31T05:05:01Z

@mhmdanas ☝☝

wangear · 2021-03-31T05:07:35Z

Thank you

triallax · 2021-03-31T05:07:41Z

@wangear I assigned you to the issue, but to be clear, you don't have to be assigned to an issue to work on it.

wangear · 2021-03-31T05:10:13Z

@mhmdanas sorry.I don't understand what you mean. Is this an issue someone is working on?

triallax · 2021-03-31T05:12:50Z

No, but I meant that you didn't have to wait for me to assign you to this issue to start working on it.

wangear · 2021-03-31T05:13:38Z

@mhmdanas Oh..I see. Thanks a lot!

…eamNewPipe#5804 issue : TeamNewPipe#5804 changed : - checked null - fixed NullPointerException.

wangear · 2021-03-31T05:29:22Z

@mhmdanas Please check pr , when you have time.

triallax · 2021-03-31T05:32:55Z

@wangear you have not opened a PR. You only pushed a commit (which is a prerequisite to open a PR). See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request for instructions on how to open a PR.

wangear · 2021-03-31T05:35:34Z

@mhmdanas ok. Sorry.

…ng-pressing 'Popup' button (#5813) * Overlapping fonts #5096 issue : #5096 * Overlapping fonts #5096 issue : #5096 changed : - If additional textView is overlapped, only title view shows. * Overlapping fonts #5096 issue : #5096 changed : - Remove treeObserve and hiding logic. - RelativeLayout -> ConstraintLayout. - layout size fixed -> wrap_content. - if text size is bigger, layout height bigger too. * Overlapping fonts #5096 issue : #5096 changed : - remove unusable variable * Crash on tapping anywhere on video after long-pressing 'Popup' button #5804 issue : #5804 changed : - checked null - fixed NullPointerException.

…ng-pressing 'Popup' button (TeamNewPipe/NewPipe#5813) * Overlapping fonts TeamNewPipe/NewPipe#5096 issue : TeamNewPipe/NewPipe#5096 * Overlapping fonts TeamNewPipe/NewPipe#5096 issue : TeamNewPipe/NewPipe#5096 changed : - If additional textView is overlapped, only title view shows. * Overlapping fonts TeamNewPipe/NewPipe#5096 issue : TeamNewPipe/NewPipe#5096 changed : - Remove treeObserve and hiding logic. - RelativeLayout -> ConstraintLayout. - layout size fixed -> wrap_content. - if text size is bigger, layout height bigger too. * Overlapping fonts TeamNewPipe/NewPipe#5096 issue : TeamNewPipe/NewPipe#5096 changed : - remove unusable variable * Crash on tapping anywhere on video after long-pressing 'Popup' button TeamNewPipe/NewPipe#5804 issue : TeamNewPipe/NewPipe#5804 changed : - checked null - fixed NullPointerException.

jarp0l added the bug Issue is related to a bug label Mar 10, 2021

AudricV added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Mar 10, 2021

triallax assigned wangear Mar 31, 2021

wangear added a commit to wangear/NewPipe that referenced this issue Mar 31, 2021

Crash on tapping anywhere on video after long-pressing 'Popup' button T…

875ed82

…eamNewPipe#5804 issue : TeamNewPipe#5804 changed : - checked null - fixed NullPointerException.

wangear mentioned this issue Mar 31, 2021

Crash on tapping anywhere on video after long-pressing 'Popup' button #5804 #5965

Closed

5 tasks

Stypox mentioned this issue Mar 31, 2021

Overlapping fonts #5096 #5813

Merged

5 tasks

Stypox closed this as completed in #5813 Mar 31, 2021

AudricV unassigned wangear Apr 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash on tapping anywhere on video after long-pressing 'Popup' button #5804

Crash on tapping anywhere on video after long-pressing 'Popup' button #5804

jarp0l commented Mar 10, 2021 •

edited

Loading

iamthesenate1 commented Mar 10, 2021

jarp0l commented Mar 11, 2021 •

edited

Loading

wangear commented Mar 11, 2021

wangear commented Mar 30, 2021

ShareASmile commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

Crash on tapping anywhere on video after long-pressing 'Popup' button #5804

Crash on tapping anywhere on video after long-pressing 'Popup' button #5804

Comments

jarp0l commented Mar 10, 2021 • edited Loading

Checklist

Steps to reproduce the bug

Actual behaviour

Expected behavior

Screenshots/Screen recordings

Logs

Exception

iamthesenate1 commented Mar 10, 2021

jarp0l commented Mar 11, 2021 • edited Loading

wangear commented Mar 11, 2021

wangear commented Mar 30, 2021

ShareASmile commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

wangear commented Mar 31, 2021

triallax commented Mar 31, 2021

wangear commented Mar 31, 2021

jarp0l commented Mar 10, 2021 •

edited

Loading

jarp0l commented Mar 11, 2021 •

edited

Loading