Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MANAGE_EXTERNAL_STORAGE permission on Android TV to properly access storage #8359

Closed
5 tasks done
opusforlife2 opened this issue May 5, 2022 · 10 comments
Closed
5 tasks done
Labels
Android TV Issue is related to Android TV device/software specific Issues that only happen on some devices or with some specific hardware/software feature request Issue is related to a feature in the app

Comments

@opusforlife2
Copy link
Collaborator

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Newpipe should use the MANAGE_EXTERNAL_STORAGE permission on Android TV devices so that file I/O works properly/bug-free.

Why do you want this feature?

Storage access seems to be broken on Android TV, which affects Newpipe's file I/O operations, such as importing subscriptions.

See #8195 (comment) and #8195 (comment) for context.

Additional information

No response

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app Android TV Issue is related to Android TV labels May 5, 2022
@opusforlife2
Copy link
Collaborator Author

@moneytoo Is this info accurate? Anything to add?

@litetex
Copy link
Member

litetex commented May 6, 2022

Not sure who is working at Google and thought "Android TV is production ready" while they forgot to "implement" the only working storage framework... WTF

Can't recommend adding that permission to the overall app:

https://developer.android.com/training/data-storage/manage-all-files

An app can request All files access from the user by doing the following:

  1. Declare the MANAGE_EXTERNAL_STORAGE permission in the manifest.

As far as I know we can only ship one manifest file for the complete app.

Also:

You should request the MANAGE_EXTERNAL_STORAGE permission only when your app cannot effectively make use of the more privacy-friendly APIs, such as Storage Access Framework or the Media Store API.

Not sure if accessing all data is a good idea - from a security viewpoint.

@opusforlife2
Copy link
Collaborator Author

As far as I know we can only ship one manifest file for the complete app.

So that means if we go ahead with this, there would need to be a separate build for Android TV?

@litetex
Copy link
Member

litetex commented May 11, 2022

So that means if we go ahead with this, there would need to be a separate build for Android TV?

I guess so :/

@litetex litetex added the device/software specific Issues that only happen on some devices or with some specific hardware/software label May 11, 2022
@opusforlife2
Copy link
Collaborator Author

We have already applied the Android TV label, though? Why device/software specific, @litetex?

@litetex
Copy link
Member

litetex commented May 16, 2022

@opusforlife2

https://commonsware.com/blog/2019/12/08/more-missing-saf.html

From one of the comments in the PR.
According to the article it works on some ¯\_(ツ)_/¯ TVs.

@Stypox
Copy link
Member

Stypox commented May 22, 2022

Can't recommend adding that permission to the overall app:

Yes, we switched to fully SAF exactly to switch away from that permission. We can't reintroduce it.

@PrzemekSkw
Copy link

Hello, I cannot import on Canal+ android tv box but I can in FireTV stick 4k max.
Regards.

@opusforlife2
Copy link
Collaborator Author

We can't reintroduce it.

So, close as wontfix, @Stypox?

@Stypox
Copy link
Member

Stypox commented Jun 10, 2022

Yes, unfortunately

@Stypox Stypox closed this as completed Jun 10, 2022
@opusforlife2 opusforlife2 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android TV Issue is related to Android TV device/software specific Issues that only happen on some devices or with some specific hardware/software feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants