Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop the notification thumbnail in 1:1 mode instead of stretching it #8478

Closed
5 tasks done
OxygenCobalt opened this issue Jun 3, 2022 · 0 comments · Fixed by #8533
Closed
5 tasks done

Crop the notification thumbnail in 1:1 mode instead of stretching it #8478

OxygenCobalt opened this issue Jun 3, 2022 · 0 comments · Fixed by #8533
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player notification Anything to do with the MediaStyle notification

Comments

@OxygenCobalt
Copy link
Contributor

OxygenCobalt commented Jun 3, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

When the "Scale thumbnail to 1:1 aspect ratio" setting is enabled, the thumbnail should be cropped down as to make it 1:1, instead of it being scaled to be 1:1.

Why do you want this feature?

While using the whole thumbnail for the notification's large icon works fine on Android 10 and below, it breaks down on Android 11/12, in which it looks out of place. The 1:1 option is also not ideal here, as it distorts the thumbnail in an unappealing manner.

Additional information

I have a fork with this fix already implemented here, I just want to know whether there are any issues with cropping the thumbnail in such a way, hence why scaling was used instead.

@OxygenCobalt OxygenCobalt added the feature request Issue is related to a feature in the app label Jun 3, 2022
@opusforlife2 opusforlife2 added the player notification Anything to do with the MediaStyle notification label Jun 11, 2022
@triallax triallax added the GUI Issue is related to the graphical user interface label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player notification Anything to do with the MediaStyle notification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants