Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tapping behind queue in main player #4353

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Prevent tapping behind queue in main player #4353

merged 2 commits into from
Sep 30, 2020

Conversation

opusforlife2
Copy link
Collaborator

@opusforlife2 opusforlife2 commented Sep 29, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Now the user cannot interact with the controls behind the video queue in the main player

Fixes the following issue(s)

  • Release 0.20.0 #4332 (comment) - "open a playlist in full-screen mode. while playing, tab the top-right button to show the queue. the bug: although the queue window is on top, you can still accidentally press the player ui buttons such as the video quality menu . I think the queue window should block player buttons until dismissed."

Test APK

tap-behind-queue.zip

Agreement

(I have no idea what I just did. Shhh! Don't tell anyone. 🤫 )
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Sep 29, 2020
@opusforlife2
Copy link
Collaborator Author

Thanks, @avently. :3

@avently
Copy link
Contributor

avently commented Sep 29, 2020

I think the same lines should be added to layout-large-land/player.xml because this file is for tablets too (not only android TV).

Signed-off-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @opusforlife2 & @avently

@TobiGr TobiGr merged commit 3a3ecc7 into TeamNewPipe:dev Sep 30, 2020
@TobiGr TobiGr mentioned this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants