Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change YouTube subscription import instructions to Google takeout #4759

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Nov 1, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This are the new steps:

  1. Go to this URL: https://takeout.google.com/takeout/custom/youtube
  2. Log in when asked
  3. Click on "All data included", then on "Deselect all", then select only "subscriptions" and click "OK"
  4. Click on "Next step" and then on "Create export"
  5. Click on the "Download" button after it appears and
  6. From the downloaded takeout zip extract the .json file (usually under "YouTube and YouTube Music/subscriptions/subscriptions.json") and import it here

Point 7, i.e. extracting things from the archive, can't be done automatically, due to the different structure for different localizations.

Fixes the following issue(s)

Fixes #4720

Relies on the following changes

TeamNewPipe/NewPipeExtractor#452

APK testing

@simula67 @inigosola @Djay86 @IvanProgramming @saecki
app-debug.zip

Due diligence

@TobiGr
Copy link
Member

TobiGr commented Nov 1, 2020

@TobiGr TobiGr added bug Issue is related to a bug youtube Service, https://www.youtube.com/ labels Nov 1, 2020
@Djay86
Copy link

Djay86 commented Nov 1, 2020

Tested the .apk, import worked with no isssue.

@IvanProgramming
Copy link

Tested .APK file, no issues was found

@saecki
Copy link

saecki commented Nov 1, 2020

Works for me too.

@Stypox
Copy link
Member Author

Stypox commented Nov 2, 2020

I updated the url to https://takeout.google.com/takeout/custom/youtube , see the extractor PR for discussion
app-debug.zip

@simula67
Copy link

simula67 commented Nov 2, 2020

@Stypox The import works with the debug app.

Thanks for doing this.

@atar-axis
Copy link

Works, the only issue is that google sends you an archive and you will have to extract the json by hand. You should therefore maybe also note that on the instructions or let newpipe extract it if necessary

@Stypox
Copy link
Member Author

Stypox commented Nov 3, 2020

@atar-axis as I said I don't think we can have NewPipe extract the json automatically, sincs different localizations have different names and structures

@atar-axis
Copy link

atar-axis commented Nov 3, 2020

I think all we need to do is extracting the .zip and searching for the json where it says [ { ..., "kind" : "youtube#subscription", ... } ] should be pretty easy I guess.

@Stypox
Copy link
Member Author

Stypox commented Nov 4, 2020

@TobiGr this should also be merged, it is only a string change

@TobiGr TobiGr merged commit 7dd317e into TeamNewPipe:dev Nov 4, 2020
@atar-axis
Copy link

atar-axis commented Nov 4, 2020

The instructions don't tell the user to extract the file and find the subscriptions.json on beforehand of importing. At least those instructions should be added before merging

@Stypox
Copy link
Member Author

Stypox commented Nov 4, 2020

@atar-axis no, it does: From the downloaded takeout zip extract the .json file (usually under "YouTube and YouTube Music/subscriptions/subscriptions.json")

@atar-axis
Copy link

So then it is an translation issue, it doesn't on the german version. Thanks for clarification!

@atar-axis
Copy link

I think all we need to do is extracting the .zip and searching for the json where it says [ { ..., "kind" : "youtube#subscription", ... } ] should be pretty easy I guess.

@Stypox what do you think about that? I could give it a try, shouldn't be too hard

@Stypox
Copy link
Member Author

Stypox commented Nov 4, 2020

So then it is an translation issue, it doesn't on the german version.

@atar-axis Oh, yeah, translations will be there only after syncing WebLate ;-)

@Stypox what do you think about that? I could give it a try, shouldn't be too hard

I am not sure if that would work out perfectly (maybe there are still issues in some localizations? idk). Anyway, after a second thought I think we should detect automatically if the user is passing us a json file directly (in which case we parse it as we do currently) or a zip archive (in which case we try to look for the json). This should bring us the best of both worlds, since we would both be able to pass a single file and the whole archive. Feel free to open a PR in the NewPipe repo (imo it's better not to put this part in the Extractor since it has to do with files, zips, etc.). Thank you :-D

@ochen1
Copy link

ochen1 commented Dec 4, 2020

The APK worked like a charm! Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug youtube Service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube import subscription instructions is not working anymore
8 participants