Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement youtube subscription import from Google takeout #452

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Nov 1, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This PR replaces the current approach of importing subscriptions (since it has been removed by YouTube) with Google takeout. Fixes TeamNewPipe/NewPipe#4720
I implemented a test with a real-world Google takeout file and it worked flawlessy.

Depends on TeamNewPipe/NewPipe#4759

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TobiGr TobiGr merged commit b13c7e1 into TeamNewPipe:dev Nov 3, 2020
@B0pol
Copy link
Member

B0pol commented Feb 20, 2021

Regression: cannot import subscriptions from invidious anymore

@nilsriga
Copy link

Hey.. Just a kind reminder to update the version on FDroid, because you got a promo on https://www.youtube.com/watch?v=ED_Yh6nsGaQ
which is the way I found out about you, but the version on FDroid still says to get the subscriptions from youtube.com/subscription_manager?action_takeout.. which doesn't work.
It took me a while to realize that I don't have the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug youtube service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube import subscription instructions is not working anymore
5 participants