Make numberFormat respect language and region settings #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Hi, I think that this change broke the site. The web doesn't show any video.
|
FireMasterK
added a commit
that referenced
this pull request
Nov 3, 2022
|
I believe that should be fixed now. |
|
Yes, everything works fine again. Thanks!. |
|
Oh sorry, I thought the matcher would automatically fallback, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,the numberFormat function will always use the fallback locale provided by Intl.NumberFormat. This PR tries to use the user's preferred language and region. If that fails, it will default to the fallback locale.