Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating __init__.py into multiple files #38

Open
mattgwwalker opened this issue Aug 27, 2020 · 3 comments
Open

Separating __init__.py into multiple files #38

mattgwwalker opened this issue Aug 27, 2020 · 3 comments
Milestone

Comments

@mattgwwalker
Copy link
Collaborator

Hi Zuzu-Typ,

Would you be open to having __init__.py separated into a number of files, say one file per class?

As it stands, it's a challenge for me to separate the work I do as everything is connected to the one file.

I'm happy to make the changes if you're happy to accept them.

Cheers,

Matthew

@mattgwwalker
Copy link
Collaborator Author

The Opus-related classes have been split out of __init__.py.

The Vorbis and FLAC classes should also be split out, but before we do that, we should create tests to ensure their correct functionality after the split.

@mattgwwalker
Copy link
Collaborator Author

The Vorbis related classes have been split from __init__.py. Examples and tests have been added. (See #49.)

Only the FLAC classes remain to be split. Examples and tests are required.

@mattgwwalker
Copy link
Collaborator Author

FLAC classes have been split and tests have been added (see pull request #58).

Examples need to be written and added to the documentation. I'll leave this issue open as a reminder.

@mattgwwalker mattgwwalker added this to the Version 0.7 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant