Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charms and Soulbound enchantments #338

Closed
Caopr opened this issue Nov 15, 2017 · 4 comments
Closed

Charms and Soulbound enchantments #338

Caopr opened this issue Nov 15, 2017 · 4 comments

Comments

@Caopr
Copy link

Caopr commented Nov 15, 2017

Forge version: 14.23.0.2531
Twilight Forest version: 3.3.202

So when using both a charm of keeping and a charm of life at once it would cause soulbound items to be destroyed.

said soulbound effects came from 2 mods. Corpse Complex. and a soulbound tinkers tool from using a nether star.

only soulbound items are destroyed from my notice. Did not seem to destroy the items if only a charm of life was used.

@Andromander
Copy link
Member

The Charm of Keeping and Charm of Life should not be working at the same time. The only item that may be destroying soulbound items is Charm of Keeping. Charm of Life only restores health once the player is meant to die.

I'm not sure how soulbound items work, so I'm not sure if there's something else in there that I'm missing

@Caopr
Copy link
Author

Caopr commented Nov 15, 2017

Oh. well when I die with both charms in my inventory the sprites for both charms fly around my character. same time.

@Caopr
Copy link
Author

Caopr commented Nov 15, 2017

Soulbound items work a bit like the charm of keeping. but as an enchantment

@TheIllusiveC4
Copy link

TheIllusiveC4 commented Nov 15, 2017

Forge version: 14.23.0.2542
Twilight Forest version: 3.3.202

I'm the author for Corpse Complex, the mod where this issue was initially opened. In my investigation of this issue, I personally found that Soulbound items were irrelevant. I tested an instance with only Forge and Twilight Forest installed and found that, upon death, both Charm of Keeping and Charm of Life will activate and the items that should have been kept by the Charm of Keeping are destroyed. I suspect that since Charm of Life activates, the items that Charm of Keeping were storing are lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants