Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Use C++'s "final" keyword to clarify design choice. #117

Closed
sainsay opened this issue Jan 11, 2019 · 1 comment
Closed

Use C++'s "final" keyword to clarify design choice. #117

sainsay opened this issue Jan 11, 2019 · 1 comment
Labels
refactor Request to re-factor a working system/class/etc.

Comments

@sainsay
Copy link
Contributor

sainsay commented Jan 11, 2019

Is your request related to a problem? Please describe.
D3D12RenderSystem class can currently be inherited from but marks all virtual functions as final giving no use to the child class. maintaining D3D12RenderSystem when the RenderSystem class changes can introduce mistakes as it is not clear that D3D12RenderSystem is not supposed to be inherited from in current design philosophy.

Describe the solution you'd like
D3D12RenderSystem class marked with the final specifier and remove in necessary final specifiers from functions. this makes all future additions to RenderSystem when virtual to be final in the D3D12RenderSystem.

Describe alternatives you've considered
none

Additional context
none

@sainsay sainsay added the refactor Request to re-factor a working system/class/etc. label Jan 11, 2019
@VZout VZout changed the title final specifier to clarify design choice. final keyword to clarify design choice. May 6, 2019
@VZout VZout changed the title final keyword to clarify design choice. Use C++'s "final" keyword to clarify design choice. May 6, 2019
@VZout
Copy link
Contributor

VZout commented May 24, 2019

Fixed in #323

@VZout VZout closed this as completed May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Request to re-factor a working system/class/etc.
Projects
None yet
Development

No branches or pull requests

2 participants