Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scaffolding to Docker Swarm #20

Closed
yajo opened this issue Mar 21, 2017 · 7 comments
Closed

Move scaffolding to Docker Swarm #20

yajo opened this issue Mar 21, 2017 · 7 comments

Comments

@yajo
Copy link
Contributor

yajo commented Mar 21, 2017

WIP of moving scaffolding to docker-compose file v3.1 and supporting only Docker Swarm (>=1.13) in prod.yaml can be found in https://github.com/Tecnativa/docker-odoo-base/tree/scaffolding-composefile3.

@lasley
Copy link
Contributor

lasley commented Jun 10, 2017

IMO it feels a bit early to deprecate the older compose files. This is just scaffold though, right? So really it's just a sample, and the user is free to use whatever?

@yajo
Copy link
Contributor Author

yajo commented Jun 12, 2017

Yeah, of course.

There's still docker/compose#4315, and I'm also considering moving the scaffolding to make use of ansible-container instead of plain docker-compose.

Still nothing decided, but keep an eye on this issue for progress 😉

@lasley
Copy link
Contributor

lasley commented Jun 13, 2017

Ahahahah I'm so happy you guys are loving Ansible!

@yajo
Copy link
Contributor Author

yajo commented Sep 18, 2017

OK, now there's a way to define different environments with v3 of docker compose file: moby/moby#31101 (comment) (it was there before, I just didn't read carefully enough).

That would count as a breaking change, but allows to move for v3. Still I'm not sure if ansible would support having v3, which is very important for us too...

@lasley
Copy link
Contributor

lasley commented Sep 20, 2017

I still think this move is quite early personally. Also, supporting only Swarm seems like cutting out a good amount of other uses out of the picture. We use Kubernetes here, and likely won't be switching any time soon.

Ansible - yeah it uses docker-py if you're using the docker module, which isn't compatible with docker-compose. People on the interwebz look to be using docker shell commands when newer syntax is required.

@yajo
Copy link
Contributor Author

yajo commented Sep 21, 2017

Well, switching to docker compose file v3+ does not force swarm, it just enables it. You can still use swarmless docker with that file version.

@yajo
Copy link
Contributor Author

yajo commented Jul 30, 2018

Will do later in https://github.com/Tecnativa/doodba-scaffolding

@yajo yajo closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants