Orbits shifting when using tracking station while in docking range

[JohannesMP]

Note: This issue was originally included in #642, but it turns out it was a separate issue (this one is -not- KSP's fault like the Apoapsis/Periapsis shifting a little bit)

Example 1:

Video at 4:01
Attempting to dock with another local client's vessel; Switching to the tracking station and back resulted in my orbit suddenly shifting to 40km behind the other vessel. I don't know which of the two ships was shifted, but this -really- annoyed me after working 20+ minutes to get the two ships close enough together

Before Tracking Station:

After Tracking Station:

You can also see the aftermath of #650

Example 2:

Video at 7:56
Attempting to dock with another user's vessel. When I realize that my friend's ship is not appearing the same on his screen as on mine (which ends up being issue #646) I revert to the tracking station and choose to fly my ship again, at which point my friend's ship is suddenly 17km away:

Before Tracking Station:

After Tracking Station:

Interestingly, in the above screenshot the user's location, as indicated by the green arrow) is not at all where my client is showing their ship.

[godarklight]

This one feels like ntp sync and time not moving forward, which makes this one mine.

EDIT: Nope, e935cee is before NTP sync was merged.

[godarklight]

This could be related to #436 and the player times getting out of sync (as this was before NTP-sync).

[JohannesMP]

Is there a chance that any recent commits would have affected this?

[TehGimp]

@JohannesMP perhaps, but I'm waiting for @godarklight to finish some recent experiments that will have a big impact on this (and our other positioning-type issues like #436, #509, #669). Once these latest experiments are done there will be a somewhat lengthy testing process to validate when and where the newly developed positioning modes are most appropriate and how best to combine/replace the existing methods with these new approaches. Once that whole process has settled down we expect to have resolved several if not all of these positioning issues.