Skip to content

Commit

Permalink
feat(net): Add response HTTP status to Networking engine responses (s…
Browse files Browse the repository at this point in the history
  • Loading branch information
Pavelas committed Sep 16, 2021
1 parent 6aac1d7 commit 2701527
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
10 changes: 5 additions & 5 deletions AUTHORS
Expand Up @@ -13,8 +13,8 @@
#
# Please keep the list sorted.

AdsWizz <*@adswizz.com>
Adrián Gómez Llorente <adgllorente@gmail.com>
AdsWizz <*@adswizz.com>
Alex Jones <alexedwardjones@gmail.com>
Alugha GmbH <*@alugha.com>
Alvaro Velad Galvan <alvaro.velad@mirada.tv>
Expand All @@ -23,16 +23,16 @@ Anthony Stansbridge <github@anthonystansbridge.co.uk>
Benjamin Wallberg <me@bwallberg.com>
Bonnier Broadcasting <*@bonnierbroadcasting.com>
Bryan Huh <bhh1988@gmail.com>
Code It <*@code-it.fr>
Charter Communications Inc <*@charter.com>
Code It <*@code-it.fr>
Damien Deis <developer.deis@gmail.com>
Dany L'Hébreux <danylhebreux@gmail.com>
Edgeware AB <*@edgeware.tv>
Esteban Dosztal <edosztal@gmail.com>
Fadomire <fadomire@gmail.com>
Google Inc. <*@google.com>
Edgeware AB <*@edgeware.tv>
Gil Gonen <gil.gonen@gmail.com>
Giuseppe Samela <giuseppe.samela@gmail.com>
Google Inc. <*@google.com>
Itay Kinnrot <Itay.Kinnrot@Kaltura.com>
Jason Palmer <jason@jason-palmer.com>
Jesper Haug Karsrud <jesper.karsrud@gmail.com>
Expand All @@ -50,6 +50,7 @@ Oskar Arvidsson <oskar@irock.se>
Patrick Cruikshank <patrick.cruikshank@gmail.com>
Patrick Kunka <patrick@kunkalabs.com>
Paul Jordaan <pdjordaan@gmail.com>
Pavel Zablockij <epavelas@gmail.com>
Percy Tse <percy.tse@gmail.com>
Peter Nycander <peter.nycander@gmail.com>
Philo Inc. <*@philo.com>
Expand All @@ -71,4 +72,3 @@ uStudio Inc. <*@ustudio.com>
Verizon Digital Media Services <*@verizondigitalmedia.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>

5 changes: 3 additions & 2 deletions CONTRIBUTORS
Expand Up @@ -31,8 +31,8 @@ Amila Sampath <lucksy@gmail.com>
Andy Hochhaus <ahochhaus@samegoal.com>
Anthony Stansbridge <github@anthonystansbridge.co.uk>
Ashutosh Kumar Mukhiya <ashukm4@gmail.com>
Benjamin Wallberg <me@bwallberg.com>
Benjamin Wallberg <benjamin.wallberg@bonnierbroadcasting.com>
Benjamin Wallberg <me@bwallberg.com>
Boris Cupac <borisrt2309@gmail.com>
Brad Nadler <bnadler@swankmp.com>
Bryan Huh <bhh1988@gmail.com>
Expand Down Expand Up @@ -78,6 +78,7 @@ Oskar Arvidsson <oskar@irock.se>
Patrick Cruikshank <patrick.cruikshank@gmail.com>
Patrick Kunka <patrick@kunkalabs.com>
Paul Jordaan <pdjordaan@gmail.com>
Pavel Zablockij <epavelas@gmail.com>
Percy Tse <percy.tse@gmail.com>
Peter Nycander <peter.nycander@gmail.com>
Prakash Duggaraju <duggaraju@gmail.com>
Expand Down Expand Up @@ -107,4 +108,4 @@ Vasanth Polipelli <vasanthap@google.com>
Vignesh Venkatasubramanian <vigneshv@google.com>
Vincent Valot <valot.vince@gmail.com>
Wayne Morgan <wayne.morgan.dev@gmail.com>
Yohann Connell <robinconnell@google.com>
Yohann Connell <robinconnell@google.com>
3 changes: 3 additions & 0 deletions externs/shaka/net.js
Expand Up @@ -101,6 +101,7 @@ shaka.extern.Request;
* @typedef {{
* uri: string,
* data: BufferSource,
* status: (number|undefined),
* headers: !Object.<string, string>,
* timeMs: (number|undefined),
* fromCache: (boolean|undefined)
Expand All @@ -119,6 +120,8 @@ shaka.extern.Request;
* redirects, but after request filters are executed.
* @property {BufferSource} data
* The body of the response.
* @property {(number|undefined)} status
* The response HTTP status code.
* @property {!Object.<string, string>} headers
* A map of response headers, if supported by the underlying protocol.
* All keys should be lowercased.
Expand Down
1 change: 1 addition & 0 deletions lib/net/http_plugin_utils.js
Expand Up @@ -34,6 +34,7 @@ shaka.net.HttpPluginUtils = class {
uri: responseURL || uri,
originalUri: uri,
data: data,
status: status,
headers: headers,
fromCache: !!headers['x-shaka-from-cache'],
};
Expand Down

0 comments on commit 2701527

Please sign in to comment.