Apply Jean-Alphonse's patches and my own #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Zatherz, now that this project is alive again, resubmit your PR with only the custom entities change. |
|
Tempus has submitted new commits, the old patches will no longer work. I feel like he can make better custom entity support. |
epfly6
pushed a commit
to epfly6/Basement-Renovator
that referenced
this pull request
Nov 27, 2021
…verhaul Ascent support for the Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jean-Alphonse (from reddit) found a way to add custom entities by making variants of already existing ones. He made a few patches for Basement Renovator to allow for changing variants of entities it. I also added a new button to duplicate a room without incrementing the variant, so that you don't forget it if you want to add more boss rooms than the number of variants until another boss. I think all of this is an useful addition to make editing rooms a lot easier.