feat: input placeholder use global config #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaosansiji
requested review from
honkinglin,
uyarn and
carolin913
as code owners
|
|
|
Size Change: +87 B (0%) Total Size: 633 kB
ℹ️ View Unchanged
|
xiaosansiji
commented
Mar 29, 2022
|
Size Change: +92 B (0%) Total Size: 633 kB
ℹ️ View Unchanged
|
1 similar comment
|
Size Change: +92 B (0%) Total Size: 633 kB
ℹ️ View Unchanged
|
uyarn
approved these changes
Mar 29, 2022
|
LGTM |
uyarn
pushed a commit
that referenced
this pull request
Apr 18, 2022
* feat: input placeholder use global config * fix: pagination inputNumber placeholder * test: update snapshot * test: update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
Input placeholder 没有用 globalconfig，导致 Input/InputNumber 未配置 placeholder 时没有默认文案展示：
修复后：
📝 更新日志
fix(Input/InputNumber): 修复未配置
placeholder时没有展示默认文案的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单