Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing raise for CompilationError in TeradataAdapter._get_one_catalog() #133

Closed
nielspardon opened this issue Dec 14, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@nielspardon
Copy link

Describe the bug

It seems that during the upgrade to dbt 1.4 the code was refactored to use the new dbt exceptions where in once instance the exception is being constructed but not being raised:

            dbt.exceptions.CompilationError(
                f'Expected only one schema in _get_one_catalog() for Teradata adapter, found '
                f'{schemas}'
            )

https://github.com/Teradata/dbt-teradata/blob/6ea3ece25130eec7dfea5c4e72a2d9e1f9dc4b29/dbt/adapters/teradata/impl.py#L172C1-L175

Steps To Reproduce

Expected behavior

The exception should be raised using the raise keyword:

            raise dbt.exceptions.CompilationError(
                f'Expected only one schema in _get_one_catalog() for Teradata adapter, found '
                f'{schemas}'
            )

Screenshots and log output

Additional context

@nielspardon nielspardon added the bug Something isn't working label Dec 14, 2023
@tallamohan
Copy link
Contributor

tallamohan commented Dec 15, 2023

@nielspardon , Thanks for catching this.
A fix for this will be available in the next dbt-teradata release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants