Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CkanCatalogGroup should handle filterQuery correctly #5331

Closed
mwu2018 opened this issue Mar 17, 2021 · 2 comments
Closed

CkanCatalogGroup should handle filterQuery correctly #5331

mwu2018 opened this issue Mar 17, 2021 · 2 comments
Assignees

Comments

@mwu2018
Copy link
Contributor

mwu2018 commented Mar 17, 2021

The current implementation assumes that each element in filterQuery array of CkanCatalogGroup is an Object that has key-value pair such as

{
  "fq": "(organization:alpine-shire-council AND res_format:(geojson OR GeoJSON OR kml OR KML OR kmz OR KMZ OR wms OR WMS OR CSV-GEO-AU OR csv-geo-au OR aus-geo-csv OR \"Esri REST\"))"
}

However, an array element can also be a pure query string such as

  "fq=+(res_format%3Awms%20OR%20res_format%3AWMS)"

The code should also handle that case.

@mwu2018 mwu2018 self-assigned this Mar 17, 2021
mwu2018 added a commit that referenced this issue Mar 17, 2021
@mwu2018 mwu2018 mentioned this issue Mar 17, 2021
2 tasks
@mwu2018
Copy link
Contributor Author

mwu2018 commented Mar 26, 2021

Changed to medium priority as this will not impact vic dt anymore. However, it is required for v8 national map.

nf-s added a commit that referenced this issue May 3, 2021
@nf-s
Copy link
Contributor

nf-s commented May 3, 2021

Closed by #5332

@nf-s nf-s closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants