Fix issue #5331. #5332
Merged
Fix issue #5331. #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nf-s
requested changes
Mar 18, 2021
nf-s
requested changes
Mar 20, 2021
lib/Models/CkanCatalogGroup.ts
Outdated
| uri.addQuery(key, filterQuery[key]) | ||
| ); | ||
| if (typeof filterQuery === "string") { | ||
| uri.query(uri.query() + "&" + filterQuery.toString()); |
There was a problem hiding this comment.
Looks good @mwu2018
Sorry to nitpick, but is it possible to use uri.addQuery() instead of uri.query(uri.query() + ...?
There was a problem hiding this comment.
@nf-s You did not nitpick at all. Instead, you have opened a can of worms 😃
- The
filterQuerytrait is changed similar to what you suggested initially. Your later suggestion does not allow mixed elements in the array. - We can not use
uri.addQuery(filterQuery)because the URI encoder will escape=, which is not what we want. I have added some comments in the code. - The code is slightly refactored in order to do simple unit tests.
Can you please take another look?
nf-s
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #5331
Checklist