Legend improvements

[nf-s]

Legend improvements

• remove legend broken image icon
• tsxify Legend
• Re-enable geoserver legend scaling
  • Also added geoserver legend font, font size and label margin
  • Add imageScaling trait
• Move LegendTraits to CatalogMemberMixin
• Comment out unused old Legend code
• Extend WMS isGeoserver to be true if URL has geoserver in it
• Add WMS supportsGetLegendRequest trait
• Improved handling of WMS default styles

Fixes #4787 and #5021

A new geoserver legend:

Checklist

• There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
• I've updated CHANGES.md with what I changed.

[reginapramesti]

@nf-s Is there a URL I can try out for this? I could only find https://services.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/ but it doesn't behave the way it does on your screenshot in the issue 😬

[nf-s]

mm that is interesting!
Not sure why that is happening

[nf-s]

Sorry @reginapramesti I got distracted!
I might just quickly turn the Legend into styled components, so I'll mark this as draft.

Test URLs:

WMS with geoserver legend

PR:

• http://ci.terria.io/remove-legend-broken-image-icon/#share=s-QkWhfRsBaPtlo0oeGbtp3qV7gm

Next:

• http://ci.terria.io/next/#share=s-QkWhfRsBaPtlo0oeGbtp3qV7gm

WMS with non-geoserver legend

PR:

• http://ci.terria.io/remove-legend-broken-image-icon/#share=s-A0RsiFEvGI4OTSMW8AJvQPD5lgr

Next:

• http://ci.terria.io/next/#share=s-A0RsiFEvGI4OTSMW8AJvQPD5lgr

WMS with no legend

Use "Delta Blended service" layer

PR:

• http://ci.terria.io/remove-legend-broken-image-icon/#clean&https://gist.githubusercontent.com/nf-s/3d77d4acb9105283226444677e011dd9/raw/290e89b66e2b2614462b33efb3628dbdd0ac7b99/wms-multidim.json

Next:

• http://ci.terria.io/next/#clean&https://gist.githubusercontent.com/nf-s/3d77d4acb9105283226444677e011dd9/raw/290e89b66e2b2614462b33efb3628dbdd0ac7b99/wms-multidim.json

A mix of things to test

http://ci.terria.io/remove-legend-broken-image-icon/#clean&https://gist.githubusercontent.com/nf-s/0077f3c5dd4df0f86b66817a7899496d/raw/ed58e13a1daf3046ec70856d16fda0888d452300/ihatelegends.json

ODC WMS with default style

https://ows.dea.ga.gov.au/?service=WMS&request=GetCapabilities

ESRI

http://www.environment.gov.au/mapping/services/ogc_services/CAPAD_MARINE/MapServer/WMSServer

MapServer

https://www.gebco.net/data_and_products/gebco_web_services/2019/mapserv?service=WMS&version=1.3.0&request=GetCapabilities

[nf-s]

Sorry @reginapramesti this has turned into a bit of a monster PR 😶

[KeyboardSounds]

👍 for adding useful comments to WebMapServiceCatalogItem