New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable basemaps from init json #5140
Conversation
- baseMaps now can be configured from init files - create default baseMaps list to reflect existing state from next - clear default baseMaps when baseMaps are provided in init file - enable configuration of dataPreview baseMap from init files
Thinking right now would it might be better to move the default list to configParameters, or adding the edit - will move this to future work, after search bar |
ect images location, and remove the old on es
While writing documentation I also converted all |
Docs are still missing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work @zoran995
Sorry it took so long to review this.
I just made some tiny changes:
-
removed references to v7 docs (catalog-items.md, catalog-groups.md...)
-
change comment in
DataPreviewMap.jsx
- // Choose positron if it's available
+ // Find preview basemap using `terria.previewBaseMapId`
-
added breaking changes notice to CHANGES.md
-
change default basemap
assetId
toionAssetId
forIonImageryCatalogItemTraits
I have made issues for the things you noted: |
What this PR does
Fixes #907
configParameters
.previewBaseMapId
init file parameter so dataset preview baseMap can be changed (there is no more a fixed list of available baseMaps so we can't be sure that positron baseMap will exist)Testing
Add this to the init file and check that there are only 2 base maps.
Pending
Future work
baseMapId
instead ofbaseMapName
- edit I couldn't get share basemap to work on ci nextbaseMapId
- so user can explicitly set the basemapcatalogItems
- done in Mappable attribution #5167Checklist