Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mappable attribution #5167

Merged
merged 5 commits into from
Jan 24, 2021
Merged

Mappable attribution #5167

merged 5 commits into from
Jan 24, 2021

Conversation

zoran995
Copy link
Contributor

@zoran995 zoran995 commented Jan 21, 2021 •
edited
Loading

What this PR does

Fixes #5162

This might also be considered as needed by #5140, to credit basemap items properly.

  • Added a AttributionTraits and included into MappableTraits.
  • Implemented it for most of the catalog items. I think that only GtfsCatalogItem is missing implementation for attribution since I couldn't figure out where to hook the attribution.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

tephenavies
tephenavies approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@tephenavies tephenavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@tephenavies tephenavies merged commit aed95ea into TerriaJS:next Jan 24, 2021
@zoran995 zoran995 deleted the mappable-attribution branch January 25, 2021 00:18
@zoran995 zoran995 mentioned this pull request Feb 2, 2021
Merged
6 tasks
@nf-s nf-s mentioned this pull request Feb 18, 2021
Closed
@zoran995 zoran995 mentioned this pull request Aug 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tephenavies tephenavies tephenavies approved these changes

Assignees
No one assigned
Labels
High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoran995 @tephenavies @AnaBelgun