Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Configurable Display type to Salesforce Auth Request #238

Merged
merged 2 commits into from
Nov 4, 2018

Conversation

sprice88
Copy link
Contributor

@sprice88 sprice88 commented May 8, 2018

Allow for change between different display types. Added Enum to handle default, with values as specified here in salesforce docs

@TerribleDev
Copy link
Owner

Hi,

sorry I havn't seen this PR. I was on vacation when you dropped this, and didn't notice until now.

/// <summary>
/// Gets or sets the display—(Optional)
/// </summary>
public Display DisplayMode { get; set; }
Copy link
Owner

@TerribleDev TerribleDev Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't This should default to page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display is an enum with Page as the default value - I can make it explicit if you would prefer?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No its fine thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to complete PR then?

@TerribleDev
Copy link
Owner

Hi, just one quick code comment if you don't mind...

@TerribleDev TerribleDev merged commit 6850514 into TerribleDev:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants