Skip to content

Commit

Permalink
fix: Fixed typos in test names, variables and method parameter name (#…
Browse files Browse the repository at this point in the history
…944)

While searching for a fix for #942, I noticed a few typos in (mostly) test method names so I fixed them. I didn't change any public methods that had any references.

I kept 'typos' like variable names that consist of multiple words but did not use camelcase, like 'newcontents'.
  • Loading branch information
brinkdinges committed Feb 14, 2023
1 parent f6a9431 commit b57922c
Show file tree
Hide file tree
Showing 12 changed files with 52 additions and 52 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -275,15 +275,15 @@ public void AddFileFromEmbeddedResource(string path, Assembly resourceAssembly,
}

/// <inheritdoc />
public void AddFilesFromEmbeddedNamespace(string path, Assembly resourceAssembly, string embeddedRresourcePath)
public void AddFilesFromEmbeddedNamespace(string path, Assembly resourceAssembly, string embeddedResourcePath)
{
var matchingResources = resourceAssembly.GetManifestResourceNames().Where(f => f.StartsWith(embeddedRresourcePath));
var matchingResources = resourceAssembly.GetManifestResourceNames().Where(f => f.StartsWith(embeddedResourcePath));
foreach (var resource in matchingResources)
{
using (var embeddedResourceStream = resourceAssembly.GetManifestResourceStream(resource))
using (var streamReader = new BinaryReader(embeddedResourceStream))
{
var fileName = resource.Substring(embeddedRresourcePath.Length + 1);
var fileName = resource.Substring(embeddedResourcePath.Length + 1);
var fileData = streamReader.ReadBytes((int)embeddedResourceStream.Length);
var filePath = Path.Combine(path, fileName);
AddFile(filePath, new MockFileData(fileData));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void MockDirectoryInfo_Attributes_ShouldReturnMinusOneForNonExistingFile(
}

[Test]
public void MockDirectoryInfo_Attributes_SetterShouldThrowDirectoryNotFoundEceptionOnNonExistingFileOrDirectory()
public void MockDirectoryInfo_Attributes_SetterShouldThrowDirectoryNotFoundExceptionOnNonExistingFileOrDirectory()
{
var fileSystem = new MockFileSystem();
var directoryInfo = new MockDirectoryInfo(fileSystem, XFS.Path(@"c:\non\existing"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPattern()
}

[Test]
public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPatternWithThreeCharacterLongFileExtension_RepectingAllDirectorySearchOption()
public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPatternWithThreeCharacterLongFileExtension_RespectingAllDirectorySearchOption()
{
// Arrange
var additionalFilePath = XFS.Path(@"c:\a\a\c.gifx");
Expand All @@ -163,7 +163,7 @@ public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPatternWith
}

[Test]
public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPatternWithThreeCharacterLongFileExtension_RepectingTopDirectorySearchOption()
public void MockDirectory_GetFiles_ShouldFilterByExtensionBasedSearchPatternWithThreeCharacterLongFileExtension_RespectingTopDirectorySearchOption()
{
// Arrange
var additionalFilePath = XFS.Path(@"c:\a\c.gifx");
Expand Down Expand Up @@ -1485,7 +1485,7 @@ public void MockDirectory_Move_ShouldMoveFiles()
}

[Test]
public void MockDirectory_Move_ShouldMoveDirectoryAtrributes()
public void MockDirectory_Move_ShouldMoveDirectoryAttributes()
{
// Arrange
var sourceDirName = XFS.Path(@"a:\folder1\");
Expand Down Expand Up @@ -1731,7 +1731,7 @@ public void MockDirectory_Move_ShouldThrowAnIOExceptionIfDirectoriesAreOnDiffere
}

[Test]
public void MockDirectory_Move_ShouldThrowADirectoryNotFoundExceptionIfDesinationDirectoryDoesNotExist()
public void MockDirectory_Move_ShouldThrowADirectoryNotFoundExceptionIfDestinationDirectoryDoesNotExist()
{
// Arrange
string sourcePath = XFS.Path(@"c:\a");
Expand All @@ -1746,7 +1746,7 @@ public void MockDirectory_Move_ShouldThrowADirectoryNotFoundExceptionIfDesinatio
}

[Test]
public void MockDirectory_Move_ShouldThrowAnIOExceptionIfDesinationDirectoryExists()
public void MockDirectory_Move_ShouldThrowAnIOExceptionIfDestinationDirectoryExists()
{
// Arrange
string sourcePath = XFS.Path(@"c:\a");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ public void MockFile_Create_DeleteOnCloseOption_FileDeletedWhenStreamIsClosed()
}

[Test]
public void MockFile_Create_EncryptedOption_FileNotYetEncryptedsWhenStreamIsOpen()
public void MockFile_Create_EncryptedOption_FileNotYetEncryptedWhenStreamIsOpen()
{
var root = XFS.Path(@"C:\");
var filePath = XFS.Path(@"C:\test.txt");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public void MockFileInfoFactory_New_ShouldReturnFileInfoForExistingFile()
}

[Test]
public void MockFileInfoFactory_New_ShouldReturnFileInfoForNonExistantFile()
public void MockFileInfoFactory_New_ShouldReturnFileInfoForNonExistentFile()
{
// Arrange
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public void MockFileInfo_Exists_ShouldReturnFalseIfFileDoesNotExistInMemoryFileS
}

[Test]
public void MockFileInfo_Exists_ShouldRetunFalseIfPathLeadsToDirectory()
public void MockFileInfo_Exists_ShouldReturnFalseIfPathLeadsToDirectory()
{
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
{
Expand Down Expand Up @@ -211,7 +211,7 @@ public void MockFileInfo_Attributes_ShouldReturnMinusOneForNonExistingFile()
}

[Test]
public void MockFileInfo_Attributes_SetterShouldThrowFileNotFoundEceptionOnNonExistingFileOrDirectory()
public void MockFileInfo_Attributes_SetterShouldThrowFileNotFoundExceptionOnNonExistingFileOrDirectory()
{
var fileSystem = new MockFileSystem();
var fileInfo = new MockFileInfo(fileSystem, XFS.Path(@"c:\non\existing\file.txt"));
Expand Down Expand Up @@ -578,7 +578,7 @@ public void MockFileInfo_MoveTo_SameSourceAndTargetIsANoOp()
}

[Test]
public void MockFileInfo_MoveTo_SameSourceAndTargetThrowsExceptionIfSourceDoesntExist()
public void MockFileInfo_MoveTo_SameSourceAndTargetThrowsExceptionIfSourceDoesNotExist()
{
var fileSystem = new MockFileSystem();
var fileInfo = fileSystem.FileInfo.New(XFS.Path(@"c:\temp\file.txt"));
Expand All @@ -590,7 +590,7 @@ public void MockFileInfo_MoveTo_SameSourceAndTargetThrowsExceptionIfSourceDoesnt
}

[Test]
public void MockFileInfo_MoveTo_ThrowsExceptionIfSourceDoesntExist()
public void MockFileInfo_MoveTo_ThrowsExceptionIfSourceDoesNotExist()
{
var fileSystem = new MockFileSystem();
var fileInfo = fileSystem.FileInfo.New(XFS.Path(@"c:\temp\file.txt"));
Expand Down Expand Up @@ -640,7 +640,7 @@ public void MockFileInfo_MoveToOnlyCaseChanging_ShouldSucceed()
}

[Test]
public void MockFileInfo_CopyTo_ThrowsExceptionIfSourceDoesntExist()
public void MockFileInfo_CopyTo_ThrowsExceptionIfSourceDoesNotExist()
{
var fileSystem = new MockFileSystem();
var fileInfo = fileSystem.FileInfo.New(XFS.Path(@"c:\temp\file.txt"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public void MockFileStream_Constructor_ReadTypeNotWritable()
}

[Test]
public void MockFileStream_Close_MultipleCallsDontThrow()
public void MockFileStream_Close_MultipleCallsDoNotThrow()
{
var fileSystem = new MockFileSystem();
var path = XFS.Path("C:\\test");
Expand All @@ -136,7 +136,7 @@ public void MockFileStream_Close_MultipleCallsDontThrow()
}

[Test]
public void MockFileStream_Dispose_MultipleCallsDontThrow()
public void MockFileStream_Dispose_MultipleCallsDoNotThrow()
{
var fileSystem = new MockFileSystem();
var path = XFS.Path("C:\\test");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void MockFileSystem_AddFile_ShouldHandleNullFileDataAsEmpty()
}

[Test]
public void MockFileSystem_AddFile_ShouldRepaceExistingFile()
public void MockFileSystem_AddFile_ShouldReplaceExistingFile()
{
var path = XFS.Path(@"c:\some\file.txt");
const string existingContent = "Existing content";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,31 +178,31 @@ static void ExecuteDefaultValueTest(Func<MockFile, string, DateTime> getDateValu
}

[Test]
public void MockFile_GetLastWriteTimeOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetLastWriteTimeOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetLastWriteTime(p));
}

[Test]
public void MockFile_GetLastWriteTimeUtcOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetLastWriteTimeUtcOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetLastWriteTimeUtc(p));
}

[Test]
public void MockFile_GetLastAccessTimeUtcOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetLastAccessTimeUtcOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetLastAccessTimeUtc(p));
}

[Test]
public void MockFile_GetLastAccessTimeOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetLastAccessTimeOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetLastAccessTime(p));
}

[Test]
public void MockFile_GetAttributeOfNonExistantFileButParentDirectoryExists_ShouldThrowOneFileNotFoundException()
public void MockFile_GetAttributeOfNonExistentFileButParentDirectoryExists_ShouldThrowOneFileNotFoundException()
{
// Arrange
var fileSystem = new MockFileSystem();
Expand All @@ -216,7 +216,7 @@ public void MockFile_GetAttributeOfNonExistantFileButParentDirectoryExists_Shoul
}

[Test]
public void MockFile_GetAttributeOfNonExistantFile_ShouldThrowOneDirectoryNotFoundException()
public void MockFile_GetAttributeOfNonExistentFile_ShouldThrowOneDirectoryNotFoundException()
{
// Arrange
var fileSystem = new MockFileSystem();
Expand Down Expand Up @@ -288,13 +288,13 @@ public void MockFile_GetAttributeWithIllegalParameter_ShouldThrowOneArgumentExce
}

[Test]
public void MockFile_GetCreationTimeOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetCreationTimeOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetCreationTime(p));
}

[Test]
public void MockFile_GetCreationTimeUtcOfNonExistantFile_ShouldReturnDefaultValue()
public void MockFile_GetCreationTimeUtcOfNonExistentFile_ShouldReturnDefaultValue()
{
ExecuteDefaultValueTest((f, p) => f.GetCreationTimeUtc(p));
}
Expand Down Expand Up @@ -498,7 +498,7 @@ public void MockFile_Delete_No_File_Does_Nothing()
}

[Test]
public void MockFile_AppendText_AppendTextToanExistingFile()
public void MockFile_AppendText_AppendTextToAnExistingFile()
{
string filepath = XFS.Path(@"c:\something\does\exist.txt");
var filesystem = new MockFileSystem(new Dictionary<string, MockFileData>
Expand Down
Loading

0 comments on commit b57922c

Please sign in to comment.