Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed typos in test names, variables and method parameter name #944

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: Fixed typos in test names, variables and method parameter name #944

merged 2 commits into from
Feb 14, 2023

Conversation

brinkdinges
Copy link
Contributor

While searching for a fix for #942, I noticed a few typos in (mostly) test method names so I fixed them. I didn't change any public methods that had any references.

I kept 'typos' like variable names that consist of multiple words but did not use camelcase, like 'newcontents'.

@brinkdinges brinkdinges changed the title Fixed typos in test names, variables and method parameter name fix: Fixed typos in test names, variables and method parameter name Feb 9, 2023
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @brinkdinges !

@mergify mergify bot merged commit b57922c into TestableIO:main Feb 14, 2023
vbreuss pushed a commit to Testably/Testably.Abstractions that referenced this pull request Feb 14, 2023
…19.1.18 (#254)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| nuget | patch | `19.1.14` -> `19.1.18` |

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions</summary>

###
[`v19.1.18`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.1.18)

##### What's Changed

- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.16 by [@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#941
- chore(deps): update danielpalme/reportgenerator-github-action action
to v5.1.17 by [@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#945
- chore(deps): update amannn/action-semantic-pull-request action to
v5.1.0 by [@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#946
- fix: Fixed typos in test names, variables and method parameter name by
[@&#8203;brinkdinges](https://togithub.com/brinkdinges) in
[TestableIO/System.IO.Abstractions#944

##### New Contributors

- [@&#8203;brinkdinges](https://togithub.com/brinkdinges) made their
first contribution in
[TestableIO/System.IO.Abstractions#944

**Full Changelog**:
TestableIO/System.IO.Abstractions@v19.1.14...v19.1.18

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEzMy4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

This is addressed in release v19.1.18.

@github-actions github-actions bot added the state: released Issues that are released label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants