Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct path for wrapped FileInfo and DirectoryInfo #1079

Merged

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 22, 2024

Use the full path when wrapping a FileInfo or DirectoryInfo to preserve the relevant information.

Fixes #1049

Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vbreuss, LGTM!

@mergify mergify bot merged commit 3d517f4 into TestableIO:main Jan 22, 2024
9 checks passed
Copy link

This is addressed in release v20.0.15.

@github-actions github-actions bot added the state: released Issues that are released label Jan 22, 2024
@vbreuss vbreuss deleted the topic/fix-path-of-wrapped-directory-info branch January 22, 2024 10:08
mergify bot pushed a commit to Testably/Testably.Abstractions that referenced this pull request Jan 22, 2024
…20.0.15 (#451)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| `20.0.4` -> `20.0.15` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v20.0.15`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.15)

#### What's Changed

- chore(deps): update dependency benchmarkdotnet to v0.13.11 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1066
- refactor: Convert Classic Assert to Constraint Model by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[TestableIO/System.IO.Abstractions#1065
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1068
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1067
- chore(deps): update dependency saucecontrol.inheritdoc to v2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1069
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1071
- chore(deps): update dependency benchmarkdotnet to v0.13.12 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1075
- chore(deps): update dependency nunit to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1058
- chore(deps): update dependency dotnet-sdk to v8.0.101 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1077
- refactor: remove workaround for Snapshooter/NUnit 4/.NET 4.6.2 compat…
by [@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[TestableIO/System.IO.Abstractions#1076
- fix: use correct path for wrapped `FileInfo` and `DirectoryInfo` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[TestableIO/System.IO.Abstractions#1079

**Full Changelog**:
TestableIO/System.IO.Abstractions@v20.0.4...v20.0.15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDirectoryInfoFactory.Wrap loses part of absolute path when used with MockFileSystem
2 participants