Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for color blindness #14

Closed
ThatXliner opened this issue Jan 5, 2021 · 6 comments · Fixed by #27
Closed

Better support for color blindness #14

ThatXliner opened this issue Jan 5, 2021 · 6 comments · Fixed by #27

Comments

@ThatXliner
Copy link
Owner

No description provided.

@KomodoKode
Copy link
Contributor

KomodoKode commented Jan 5, 2021

I suggest making a custom version of the theme for better color-blind usability. You can change the theme colors I have seen it on Atom UI/Syntax Theme READMEs.

@ThatXliner
Copy link
Owner Author

A specialized version of the theme? Not just improve the colors of this? Sure. "General usability" isn't a design point (although "look good" is one of them)

@KomodoKode
Copy link
Contributor

KomodoKode commented Jan 6, 2021

This is the theme without any color :
Theme without any color

when I was playing with the color filters, I found all of the colors to contrast fine under all of the filters, grayscale being the only exception.

I believe this issue can be solved by changing the "lightness" in HSL mode for better contrast.

@ThatXliner
Copy link
Owner Author

That's actually not as bad as I expected! The function/class definitions still contrasts!

@ThatXliner
Copy link
Owner Author

@KomodoKode You can pull request some tweaked colors.

Remember, the average dev workflow is:
git clone

cd fall-syntax

apm link . --dev

<Open it in dev mode>

@KomodoKode
Copy link
Contributor

Got it, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants