#1512 Update behaviour of rl_unix_word_rubout

[edi9999]

Closes #1512

Now, unix_word_rubout behaves like in bash, eg it deletes the last word in the command line.

For example , if you type

:open -t https://github.com/The-Compiler/qutebrowser/

and your cursor is at the end of the line, hitting c-w will bring you to :open -t.

If you liked the previous behaviour, you can use Ctrl-Backspace

---

This change is 

[codecov-io]

Current coverage is 81.43%

Merging #1592 into master will decrease coverage by 0.02%

@@             master      #1592   diff @@
==========================================
  Files           106        106          
  Lines         15374      15386    +12   
  Methods           0          0          
  Messages          0          0          
  Branches       2463       2465     +2   
==========================================
+ Hits          12524      12530     +6   
- Misses         2382       2386     +4   
- Partials        468        470     +2   

Powered by Codecov. Last updated by 2b28574...bfeba3c

[The-Compiler]

Thanks! Could you please adjust test_rl_unix_word_rubout in tests/unit/misc/test_readline.py to add a new test for this?

I also wonder if this code could be simplified a bit by using split.simple_split (in utils/split.py) and len() based on the text - what do you think?

[edi9999]

Hi, I have just added a test for the new readline behaviour.

Regarding simple_split, here is what I found out :

simple_split(':open -t ls ', True)
gives :
[':open', ' -t', ' ls', ' ']

However, since we want to remove ls (without the leading space), we would actually want to have the spaces 'appended' at the end of the words.

Here's what we could do :

simple_split(':open -t ls ', True, append_to="right")
[':open ', '-t ', 'ls ']

Do you want me to add another parameter for that ? I find the simple_split method a bit complicated to understand if I add this.

[edi9999]

What do you think of my last comments ?

[The-Compiler]

Sorry for the silence, I was busy with the pytest sprint and then with my wisdom tooth being pulled... I still have some other stuff to do, but I'll try to get back to this today or tomorrow.

[The-Compiler]

Gah, still didn't get to this. I hope I can take care of it later today or tomorrow.

[The-Compiler]

I tried playing with some simpler solutions based on str.rsplit but couldn't come up with anything that works correctly with all corner cases - I'll merge this as-is 😉

Thanks for the patience and the PR!

[edi9999]

No problem, i also don't think it was easy to achieve with str_split.

Thanks anyway!