Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Delete Peak button #96

Open
Radascript opened this issue Jun 25, 2022 · 0 comments
Open

Feat: Delete Peak button #96

Radascript opened this issue Jun 25, 2022 · 0 comments

Comments

@Radascript
Copy link
Collaborator

Radascript commented Jun 25, 2022

  • IMPORTANT: only works if select_peak(), b_click() and dashboard() are included directly in the notebook. When exact copies are only loaded from the viz.py script, removing peak does not work.
  • IMPORTANT: the b_click() has a really yucky issue: raw_data_dict and dash_p variables are hard coded and they are environment dependent... That's really bad. I need to figure out how to pass parameters to the event bound to the button!
  • Refactor: Dashboard / Delete button very not DRY code moment. currently I literally reuse same code in parts of dashboard() and b_click() functions. Obv need to be moved into its own function but it's a little annoying.
  • Enhancement: Would be nice to add a message below Delete button saying smth like "Peak 80042 for MU 0 has been deleted."
  • Enhancement: Would be nice to add ctrl+Z functionality to un-delete
@Radascript Radascript changed the title Dashboard / Delete button very not DRY code moment Delete Peak button TODOs Jun 25, 2022
@danfke danfke changed the title Delete Peak button TODOs Feat: Delete Peak button Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant