Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] error path joining of get_design_path util #1450

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

yihuajack
Copy link
Contributor

@yihuajack yihuajack commented Oct 25, 2022

The get_design_path function in utils.py has a bug. To run python3 run_designs.py --regression scripts/config/regression.config spm, it will show error:

Traceback (most recent call last):
File "run_designs.py", line 423, in
cli()
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1128, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.6/site-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "run_designs.py", line 338, in cli
ConfigHandler.gen_base_config(design, base_config_path)
File "/openlane/scripts/config/config.py", line 105, in gen_base_config
copyfile(config_file, base_config_file)
File "/usr/lib64/python3.6/shutil.py", line 120, in copyfile
with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/openlane/./designs/spm/config.tcl'

This is because os.path.join(os.getcwd(), f"./designs/{design}/") is '/openlane/./designs/spm/'.

yihuajack and others added 2 commits October 25, 2022 15:30
Signed-off-by: Mohamed Gaber <me@donn.website>
@donn
Copy link
Collaborator

donn commented Oct 25, 2022

Went ahead and decided to make things more consistent- let's see if anything breaks

@donn donn self-requested a review October 25, 2022 18:04
@donn donn merged commit 41ed003 into The-OpenROAD-Project:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants