Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_site_remover.py with nucleic acid sequences #107

Closed
aguang opened this issue Nov 15, 2023 · 3 comments · Fixed by #109
Closed

fast_site_remover.py with nucleic acid sequences #107

aguang opened this issue Nov 15, 2023 · 3 comments · Fixed by #109
Labels
enhancement New feature or request

Comments

@aguang
Copy link
Contributor

aguang commented Nov 15, 2023

Hi, thanks for this great tool. I used fast_site_remover.py to identify my fastest evolving sites for a project I am working on, however I had nucleic acid sequences rather than amino acid sequences. I ended up modifying the script to use nucleic acid sequences and also to print out the indices of the fastest evolving sites both through optional arguments. Would these modifications be of interest to you? If so I can open a pull request with them.

@atice
Copy link
Collaborator

atice commented Nov 15, 2023

Hi @aguang

these sound like great additions to the code! Feel free to open a pull request and when @robert-ervin-jones and I have time we can review your edits and see about making them permanent additions and documenting the new functionality. Thanks for asking!

Alex

@atice
Copy link
Collaborator

atice commented Dec 1, 2023

Hi @aguang

Just wanted to touch base with you on this again. Let us know if you are still interested in providing us with the modifications you have made to our code.

Alex

@aguang
Copy link
Contributor Author

aguang commented Dec 4, 2023

I just made a pull request for it, I think it should have the file modifications

@robert-ervin-jones robert-ervin-jones added the enhancement New feature or request label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants