Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

[Feature Request] Host/Motherboard/Device model name #102

Closed
LukeHuckman opened this issue Jun 12, 2021 · 6 comments
Closed

[Feature Request] Host/Motherboard/Device model name #102

LukeHuckman opened this issue Jun 12, 2021 · 6 comments

Comments

@LukeHuckman
Copy link
Contributor

Another system information that seems like it might be worth adding. I don't exactly know how it would be implemented for different platforms though, but I think it's doable.

@dqnk
Copy link
Contributor

dqnk commented Jun 12, 2021

I don't know if this is really important, because other popular fetch tools (neofetch) don't show it.

@LukeHuckman
Copy link
Contributor Author

Neofetch does actually. It's highlighted in the screenshot here:
image

@ad-oliviero
Copy link
Owner

To get this info, uwufetch could read /sys/devices/virtual/dmi/id/product_name to get the product name, or /sys/devices/virtual/dmi/id/board_name to get motherboard name and product name:

Schermata da 2021-06-12 17-53-38

@LukeHuckman
Copy link
Contributor Author

LukeHuckman commented Jun 12, 2021

Is the path the same for Android and non-Linux based OSes?

Also, there are some cases where one of those paths is not used, i.e. the motherboard vendor left it empty with a placeholder value like this:
image

@ad-oliviero
Copy link
Owner

Is the path the same for Android and non-Linux based OSes?

On Android this files do not exist, so getprop ro.product.model is the only way to get it.
On Mac os and other bsd systems /sys/devices/virtual/dmi/id/* should exist, but I am not sure.

Also, there are some cases where one of those paths is not used, i.e. the motherboard vendor left it empty with a placeholder value like this:

In that case the other file will be read.

I'll work on it later.

@ad-oliviero
Copy link
Owner

ad-oliviero commented Jun 13, 2021

In the last update (664fa5c) I used /sys/devices/virtual/dmi/id/product_name, that gives the best result on my desktop and on my laptop, and also works in most of my vms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants